* [dpdk-dev] [PATCH] net/qede: fix link state configuration
@ 2020-05-12 0:46 Rasesh Mody
2020-05-13 16:24 ` Jerin Jacob
2020-05-14 4:09 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
0 siblings, 2 replies; 5+ messages in thread
From: Rasesh Mody @ 2020-05-12 0:46 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit
Cc: Rasesh Mody, GR-Everest-DPDK-Dev, stable, Shahed Shaikh, Igor Russkikh
Move link state enable/disable to dev_start() and dev_stop()
respectively. This will ensure when devices are stopped,
link status will be appropriately shown as down.
Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index bcd8252d9..9a5847076 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
if (qede_activate_vport(eth_dev, true))
goto err;
+ /* Bring-up the link */
+ qede_dev_set_link_state(eth_dev, true);
+
/* Update link status */
qede_link_update(eth_dev, 0);
@@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
*/
qede_assign_rxtx_handlers(eth_dev, true);
+ /* Bring the link down */
+ qede_dev_set_link_state(eth_dev, false);
+
+ /* Update link status */
+ qede_link_update(eth_dev, 0);
+
/* Disable vport */
if (qede_activate_vport(eth_dev, false))
return;
@@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
eth_dev->data->nb_rx_queues = 0;
eth_dev->data->nb_tx_queues = 0;
- /* Bring the link down */
- qede_dev_set_link_state(eth_dev, false);
qdev->ops->common->slowpath_stop(edev);
qdev->ops->common->remove(edev);
rte_intr_disable(&pci_dev->intr_handle);
@@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;
- /* Bring-up the link */
- qede_dev_set_link_state(eth_dev, true);
-
adapter->num_tx_queues = 0;
adapter->num_rx_queues = 0;
SLIST_INIT(&adapter->arfs_info.arfs_list_head);
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/qede: fix link state configuration
2020-05-12 0:46 [dpdk-dev] [PATCH] net/qede: fix link state configuration Rasesh Mody
@ 2020-05-13 16:24 ` Jerin Jacob
2020-05-14 4:11 ` [dpdk-dev] [EXT] " Rasesh Mody
2020-05-14 4:09 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
1 sibling, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2020-05-13 16:24 UTC (permalink / raw)
To: Rasesh Mody
Cc: dpdk-dev, Jerin Jacob, Ferruh Yigit, GR-Everest-DPDK-Dev,
dpdk stable, Shahed Shaikh, Igor Russkikh
On Tue, May 12, 2020 at 6:16 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> Move link state enable/disable to dev_start() and dev_stop()
> respectively. This will ensure when devices are stopped,
> link status will be appropriately shown as down.
>
> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
I assume you need this patch for -rc3.
Please rebase the patch to dpdk-next-net-mrvl and send v2.
log:
git am -3 /tmp/to_merge/net-qede-fix-link-state-configuration
Applying: net/qede: fix link state configuration
error: sha1 information is lacking or useless (drivers/net/qede/qede_ethdev.c).
error: could not build fake ancestor
Patch failed at 0001 net/qede: fix link state configuration
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
HEAD is now at a8b8a8631 node: fix arm64 build with old gcc
git am failed /tmp/g//net-qede-fix-link-state-configuration
Wed 13 May 2020 09:51:26 PM IST
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> ---
> drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index bcd8252d9..9a5847076 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
> if (qede_activate_vport(eth_dev, true))
> goto err;
>
> + /* Bring-up the link */
> + qede_dev_set_link_state(eth_dev, true);
> +
> /* Update link status */
> qede_link_update(eth_dev, 0);
>
> @@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
> */
> qede_assign_rxtx_handlers(eth_dev, true);
>
> + /* Bring the link down */
> + qede_dev_set_link_state(eth_dev, false);
> +
> + /* Update link status */
> + qede_link_update(eth_dev, 0);
> +
> /* Disable vport */
> if (qede_activate_vport(eth_dev, false))
> return;
> @@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
> eth_dev->data->nb_rx_queues = 0;
> eth_dev->data->nb_tx_queues = 0;
>
> - /* Bring the link down */
> - qede_dev_set_link_state(eth_dev, false);
> qdev->ops->common->slowpath_stop(edev);
> qdev->ops->common->remove(edev);
> rte_intr_disable(&pci_dev->intr_handle);
> @@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
>
> eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;
>
> - /* Bring-up the link */
> - qede_dev_set_link_state(eth_dev, true);
> -
> adapter->num_tx_queues = 0;
> adapter->num_rx_queues = 0;
> SLIST_INIT(&adapter->arfs_info.arfs_list_head);
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [EXT] Re: [PATCH] net/qede: fix link state configuration
2020-05-13 16:24 ` Jerin Jacob
@ 2020-05-14 4:11 ` Rasesh Mody
2020-05-14 10:17 ` Jerin Jacob
0 siblings, 1 reply; 5+ messages in thread
From: Rasesh Mody @ 2020-05-14 4:11 UTC (permalink / raw)
To: Jerin Jacob
Cc: dpdk-dev, Jerin Jacob Kollanukkaran, Ferruh Yigit,
GR-Everest-DPDK-Dev, dpdk stable, Shahed Shaikh, Igor Russkikh
Hi Jerin,
>From: Jerin Jacob <jerinjacobk@gmail.com>
>Sent: Wednesday, May 13, 2020 9:25 AM
>
>On Tue, May 12, 2020 at 6:16 AM Rasesh Mody <rmody@marvell.com> wrote:
>>
>> Move link state enable/disable to dev_start() and dev_stop()
>> respectively. This will ensure when devices are stopped, link status
>> will be appropriately shown as down.
>>
>> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
>
>I assume you need this patch for -rc3.
>Please rebase the patch to dpdk-next-net-mrvl and send v2.
Yes, this patch is for -rc3.
This patch had a dependency on https://patches.dpdk.org/patch/69737/.
I've submitted a v2 for this patch, please apply.
Thanks!
-Rasesh
>
>log:
>git am -3 /tmp/to_merge/net-qede-fix-link-state-configuration
>
>Applying: net/qede: fix link state configuration
>error: sha1 information is lacking or useless
>(drivers/net/qede/qede_ethdev.c).
>error: could not build fake ancestor
>Patch failed at 0001 net/qede: fix link state configuration
>hint: Use 'git am --show-current-patch=diff' to see the failed patch When you
>have resolved this problem, run "git am --continue".
>If you prefer to skip this patch, run "git am --skip" instead.
>To restore the original branch and stop patching, run "git am --abort".
>HEAD is now at a8b8a8631 node: fix arm64 build with old gcc git am failed
>/tmp/g//net-qede-fix-link-state-configuration
>Wed 13 May 2020 09:51:26 PM IST
>
>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>> ---
>> drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/qede/qede_ethdev.c
>> b/drivers/net/qede/qede_ethdev.c index bcd8252d9..9a5847076 100644
>> --- a/drivers/net/qede/qede_ethdev.c
>> +++ b/drivers/net/qede/qede_ethdev.c
>> @@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev
>*eth_dev)
>> if (qede_activate_vport(eth_dev, true))
>> goto err;
>>
>> + /* Bring-up the link */
>> + qede_dev_set_link_state(eth_dev, true);
>> +
>> /* Update link status */
>> qede_link_update(eth_dev, 0);
>>
>> @@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev
>*eth_dev)
>> */
>> qede_assign_rxtx_handlers(eth_dev, true);
>>
>> + /* Bring the link down */
>> + qede_dev_set_link_state(eth_dev, false);
>> +
>> + /* Update link status */
>> + qede_link_update(eth_dev, 0);
>> +
>> /* Disable vport */
>> if (qede_activate_vport(eth_dev, false))
>> return;
>> @@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev
>*eth_dev)
>> eth_dev->data->nb_rx_queues = 0;
>> eth_dev->data->nb_tx_queues = 0;
>>
>> - /* Bring the link down */
>> - qede_dev_set_link_state(eth_dev, false);
>> qdev->ops->common->slowpath_stop(edev);
>> qdev->ops->common->remove(edev);
>> rte_intr_disable(&pci_dev->intr_handle);
>> @@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct
>> rte_eth_dev *eth_dev, bool is_vf)
>>
>> eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops :
>> &qede_eth_dev_ops;
>>
>> - /* Bring-up the link */
>> - qede_dev_set_link_state(eth_dev, true);
>> -
>> adapter->num_tx_queues = 0;
>> adapter->num_rx_queues = 0;
>> SLIST_INIT(&adapter->arfs_info.arfs_list_head);
>> --
>> 2.18.0
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [EXT] Re: [PATCH] net/qede: fix link state configuration
2020-05-14 4:11 ` [dpdk-dev] [EXT] " Rasesh Mody
@ 2020-05-14 10:17 ` Jerin Jacob
0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2020-05-14 10:17 UTC (permalink / raw)
To: Rasesh Mody
Cc: dpdk-dev, Jerin Jacob Kollanukkaran, Ferruh Yigit,
GR-Everest-DPDK-Dev, dpdk stable, Shahed Shaikh, Igor Russkikh
On Thu, May 14, 2020 at 9:41 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> Hi Jerin,
>
> >From: Jerin Jacob <jerinjacobk@gmail.com>
> >Sent: Wednesday, May 13, 2020 9:25 AM
> >
> >On Tue, May 12, 2020 at 6:16 AM Rasesh Mody <rmody@marvell.com> wrote:
> >>
> >> Move link state enable/disable to dev_start() and dev_stop()
> >> respectively. This will ensure when devices are stopped, link status
> >> will be appropriately shown as down.
> >>
> >> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
> >
> >I assume you need this patch for -rc3.
> >Please rebase the patch to dpdk-next-net-mrvl and send v2.
>
> Yes, this patch is for -rc3.
> This patch had a dependency on https://patches.dpdk.org/patch/69737/.
> I've submitted a v2 for this patch, please apply.
Applied to dpdk-next-net-mrvl/master. Thanks
>
> Thanks!
> -Rasesh
> >
> >log:
> >git am -3 /tmp/to_merge/net-qede-fix-link-state-configuration
> >
> >Applying: net/qede: fix link state configuration
> >error: sha1 information is lacking or useless
> >(drivers/net/qede/qede_ethdev.c).
> >error: could not build fake ancestor
> >Patch failed at 0001 net/qede: fix link state configuration
> >hint: Use 'git am --show-current-patch=diff' to see the failed patch When you
> >have resolved this problem, run "git am --continue".
> >If you prefer to skip this patch, run "git am --skip" instead.
> >To restore the original branch and stop patching, run "git am --abort".
> >HEAD is now at a8b8a8631 node: fix arm64 build with old gcc git am failed
> >/tmp/g//net-qede-fix-link-state-configuration
> >Wed 13 May 2020 09:51:26 PM IST
> >
> >
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
> >> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> >> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> >> ---
> >> drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
> >> 1 file changed, 9 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/net/qede/qede_ethdev.c
> >> b/drivers/net/qede/qede_ethdev.c index bcd8252d9..9a5847076 100644
> >> --- a/drivers/net/qede/qede_ethdev.c
> >> +++ b/drivers/net/qede/qede_ethdev.c
> >> @@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev
> >*eth_dev)
> >> if (qede_activate_vport(eth_dev, true))
> >> goto err;
> >>
> >> + /* Bring-up the link */
> >> + qede_dev_set_link_state(eth_dev, true);
> >> +
> >> /* Update link status */
> >> qede_link_update(eth_dev, 0);
> >>
> >> @@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev
> >*eth_dev)
> >> */
> >> qede_assign_rxtx_handlers(eth_dev, true);
> >>
> >> + /* Bring the link down */
> >> + qede_dev_set_link_state(eth_dev, false);
> >> +
> >> + /* Update link status */
> >> + qede_link_update(eth_dev, 0);
> >> +
> >> /* Disable vport */
> >> if (qede_activate_vport(eth_dev, false))
> >> return;
> >> @@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev
> >*eth_dev)
> >> eth_dev->data->nb_rx_queues = 0;
> >> eth_dev->data->nb_tx_queues = 0;
> >>
> >> - /* Bring the link down */
> >> - qede_dev_set_link_state(eth_dev, false);
> >> qdev->ops->common->slowpath_stop(edev);
> >> qdev->ops->common->remove(edev);
> >> rte_intr_disable(&pci_dev->intr_handle);
> >> @@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct
> >> rte_eth_dev *eth_dev, bool is_vf)
> >>
> >> eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops :
> >> &qede_eth_dev_ops;
> >>
> >> - /* Bring-up the link */
> >> - qede_dev_set_link_state(eth_dev, true);
> >> -
> >> adapter->num_tx_queues = 0;
> >> adapter->num_rx_queues = 0;
> >> SLIST_INIT(&adapter->arfs_info.arfs_list_head);
> >> --
> >> 2.18.0
> >>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] net/qede: fix link state configuration
2020-05-12 0:46 [dpdk-dev] [PATCH] net/qede: fix link state configuration Rasesh Mody
2020-05-13 16:24 ` Jerin Jacob
@ 2020-05-14 4:09 ` Rasesh Mody
1 sibling, 0 replies; 5+ messages in thread
From: Rasesh Mody @ 2020-05-14 4:09 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit
Cc: Rasesh Mody, GR-Everest-DPDK-Dev, stable, Shahed Shaikh, Igor Russkikh
Move link state enable/disable to dev_start() and dev_stop()
respectively. This will ensure when devices are stopped,
link status will be appropriately shown as down.
Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index e71fa1e6a..0b1fca9ac 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1144,6 +1144,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
if (qede_activate_vport(eth_dev, true))
goto err;
+ /* Bring-up the link */
+ qede_dev_set_link_state(eth_dev, true);
+
/* Update link status */
qede_link_update(eth_dev, 0);
@@ -1166,6 +1169,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
PMD_INIT_FUNC_TRACE(edev);
+ /* Bring the link down */
+ qede_dev_set_link_state(eth_dev, false);
+
+ /* Update link status */
+ qede_link_update(eth_dev, 0);
+
/* Disable vport */
if (qede_activate_vport(eth_dev, false))
return;
@@ -1550,8 +1559,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
eth_dev->data->nb_rx_queues = 0;
eth_dev->data->nb_tx_queues = 0;
- /* Bring the link down */
- qede_dev_set_link_state(eth_dev, false);
qdev->ops->common->slowpath_stop(edev);
qdev->ops->common->remove(edev);
rte_intr_disable(&pci_dev->intr_handle);
@@ -2672,9 +2679,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;
- /* Bring-up the link */
- qede_dev_set_link_state(eth_dev, true);
-
adapter->num_tx_queues = 0;
adapter->num_rx_queues = 0;
SLIST_INIT(&adapter->arfs_info.arfs_list_head);
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-14 10:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 0:46 [dpdk-dev] [PATCH] net/qede: fix link state configuration Rasesh Mody
2020-05-13 16:24 ` Jerin Jacob
2020-05-14 4:11 ` [dpdk-dev] [EXT] " Rasesh Mody
2020-05-14 10:17 ` Jerin Jacob
2020-05-14 4:09 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).