From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27AF4A00C3; Fri, 15 May 2020 08:58:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8E641DA20; Fri, 15 May 2020 08:58:25 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 30DDF1D9FE for ; Fri, 15 May 2020 08:58:23 +0200 (CEST) IronPort-SDR: RS+Lu1JL5Jet2Uv3BVRJjJFGMmkRl84dLrsvJCvuTTuJ/pxGkF1DbIYrp16KHYkKsD9YM1QA4Z LWo5Co8X6p0Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 23:58:23 -0700 IronPort-SDR: xzYdXAU9bOK8OnefSjOVy42UeiB32g+xlF8xKvpxGKXbRE3IQml9NnCNED64YjE2edLb3S4eKO eplvtTWELF8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="253714264" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 14 May 2020 23:58:22 -0700 Date: Fri, 15 May 2020 14:50:06 +0800 From: Ye Xiaolong To: Simei Su Cc: qi.z.zhang@intel.com, dev@dpdk.org, yahui.cao@intel.com Message-ID: <20200515065006.GB114443@intel.com> References: <1588900942-380047-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588900942-380047-1-git-send-email-simei.su@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, simei On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") This commit doesn't make sense to me, it just change the function to static, so should have any functional impact. Thanks, Xiaolong > >Signed-off-by: Simei Su >--- > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c >index c703a7c..33a1732 100644 >--- a/drivers/net/ice/base/ice_fdir.c >+++ b/drivers/net/ice/base/ice_fdir.c >@@ -465,6 +465,10 @@ > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; > fdir_fltr_ctx.qindex = 0; >+ } else if (input->dest_ctl == >+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { >+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; >+ fdir_fltr_ctx.qindex = 0; > } else { > if (input->dest_ctl == > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) >@@ -476,7 +480,10 @@ > fdir_fltr_ctx.cnt_index = input->cnt_index; > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; >- fdir_fltr_ctx.toq_prio = 3; >+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) >+ fdir_fltr_ctx.toq_prio = 0; >+ else >+ fdir_fltr_ctx.toq_prio = 3; > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; >-- >1.8.3.1 >