From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69DE2A00C3; Fri, 15 May 2020 10:53:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01E3D1DAA4; Fri, 15 May 2020 10:53:38 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 90E831DAA1 for ; Fri, 15 May 2020 10:53:36 +0200 (CEST) IronPort-SDR: 4aXlSJKLMKHHzPY7kDH/SVlDc3CmNwLeq5X32OIPXFQhZsu8lys17x/4/RxXbQkhc0zAiFJxRy Sa30OY3p1Ilw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 01:53:35 -0700 IronPort-SDR: pVPthwbM9IuyEwhuIwy55O26Ouo38dCLr+uHM6rOPro5WKRs6tFJhjMmSlPGXjj8H/RGOmwyBg HjiNbWdjMPVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="263129895" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by orsmga003.jf.intel.com with ESMTP; 15 May 2020 01:53:32 -0700 Date: Fri, 15 May 2020 16:45:16 +0800 From: Ye Xiaolong To: Maxime Coquelin Cc: shahafs@mellanox.com, matan@mellanox.com, amorenoz@redhat.com, xiao.w.wang@intel.com, viacheslavo@mellanox.com, dev@dpdk.org, jasowang@redhat.com, lulu@redhat.com Message-ID: <20200515084516.GD1064@intel.com> References: <20200514080218.1435344-1-maxime.coquelin@redhat.com> <20200514080218.1435344-4-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514080218.1435344-4-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/14, Maxime Coquelin wrote: >This patch adds support to enabling and disabling >vrings on a per-vring granularity. > >Signed-off-by: Maxime Coquelin >--- > drivers/vdpa/ifc/base/ifcvf.c | 9 +++++++++ > drivers/vdpa/ifc/base/ifcvf.h | 4 ++++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 23 ++++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) > >diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c >index 3c0b2dff66..dd4e7468ae 100644 >--- a/drivers/vdpa/ifc/base/ifcvf.c >+++ b/drivers/vdpa/ifc/base/ifcvf.c >@@ -327,3 +327,12 @@ ifcvf_get_queue_notify_off(struct ifcvf_hw *hw, int qid) > return (u8 *)hw->notify_addr[qid] - > (u8 *)hw->mem_resource[hw->notify_region].addr; > } >+ >+void >+ifcvf_queue_enable(struct ifcvf_hw *hw, u16 qid, u16 enable) >+{ >+ struct ifcvf_pci_common_cfg *cfg = hw->common_cfg; >+ >+ IFCVF_WRITE_REG16(qid, &cfg->queue_select); >+ IFCVF_WRITE_REG16(enable, &cfg->queue_enable); >+} >diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h >index eb04a94067..bd85010eff 100644 >--- a/drivers/vdpa/ifc/base/ifcvf.h >+++ b/drivers/vdpa/ifc/base/ifcvf.h >@@ -159,4 +159,8 @@ ifcvf_get_notify_region(struct ifcvf_hw *hw); > u64 > ifcvf_get_queue_notify_off(struct ifcvf_hw *hw, int qid); > >+void >+ifcvf_queue_enable(struct ifcvf_hw *hw, u16 qid, u16 enable); >+ >+ > #endif /* _IFCVF_H_ */ >diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c >index ec97178dcb..55ce0cf13d 100644 >--- a/drivers/vdpa/ifc/ifcvf_vdpa.c >+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c >@@ -937,6 +937,27 @@ ifcvf_dev_close(int vid) > return 0; > } > >+static int >+ifcvf_set_vring_state(int vid, int vring, int state) >+{ >+ int did; >+ struct internal_list *list; >+ struct ifcvf_internal *internal; >+ >+ did = rte_vhost_get_vdpa_device_id(vid); >+ list = find_internal_resource_by_did(did); >+ if (list == NULL) { >+ DRV_LOG(ERR, "Invalid device id: %d", did); >+ return -1; >+ } Do we need the sanity check for the vring as well? Thanks, Xiaolong >+ >+ internal = list->internal; >+ >+ ifcvf_queue_enable(&internal->hw, (uint16_t)vring, (uint16_t) state); >+ >+ return 0; >+} >+ > static int > ifcvf_set_features(int vid) > { >@@ -1086,7 +1107,7 @@ static struct rte_vdpa_dev_ops ifcvf_ops = { > .get_protocol_features = ifcvf_get_protocol_features, > .dev_conf = ifcvf_dev_config, > .dev_close = ifcvf_dev_close, >- .set_vring_state = NULL, >+ .set_vring_state = ifcvf_set_vring_state, > .set_features = ifcvf_set_features, > .migration_done = NULL, > .get_vfio_group_fd = ifcvf_get_vfio_group_fd, >-- >2.25.4 >