From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12382A0093; Wed, 20 May 2020 12:08:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C92541C43B; Wed, 20 May 2020 12:08:22 +0200 (CEST) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id 4FB481C439 for ; Wed, 20 May 2020 12:08:22 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id 82so1966686lfh.2 for ; Wed, 20 May 2020 03:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rk+yRvJn0SOR3pLBVwhHYUrDbFnhiuuL+Y157AbLMX8=; b=UxO+vGCK5WOJxURVg7A0bm7GkAFad5Hv3Gq/GgvcacR14VZxAuBD12ZUyyu8Sm09Wr wx6hV17kFbAnclXOmk18ngt+RoU8FS13RCINZN6Fnj/tlrIXHufgQwrMnUgNuxfOTj8g PbWXy+LnRwuDr4d7VoOXgfVjFLwKbxV8CXq4LCBkeW9XgOC5zlA9er2z+zuhApyB9Mk9 Z8N2gUvGNruHx45MII0fxwLicP9q5f8k0KWreFeRTQZ8+cLPfCD5qiwOcUDfx847FTzb b1F1qP9XCCjtxdsUQLxNkLnZEXy+2v7ZnqMQe5eX6ogBrISxLEWzLxUcQHS6fQ4eW6m3 PSYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rk+yRvJn0SOR3pLBVwhHYUrDbFnhiuuL+Y157AbLMX8=; b=lp0bITR+wuNSJQn7HwuFWCj4gaCYCDoSdicxn7Rs3cosei5aZQMtIT6pHVL0eZOd4z /gg9JxQq4sFZYhaIKbVvEX7HLc1Ewmfdh0H3O/Bh0FSxkBcM1lwFQXJH8XV9tEuLtRYI RGf4dVrF+F4YHgv7C0mg88AS5p61y7g+RWr/1Cjx4Q+F62RSpRXbs1p0KlCm+u3rrsp5 NGkG16rgOPp8dJb2Q2NFu1iVobKGJATQ9eycThDygz0PPCEIQvI3qK5QdXSSWlJOKAbp 8moehn4mvn5sJteVho0JMxE5bt2HKUMwN0FU+BdmN70JKEwz3moYUcsTi0zdrXuehsP3 UI2w== X-Gm-Message-State: AOAM533m+QBd6IaDjvKvf6WqVknBYjIpsyKzah+5EbqqodK2qexEgHJg zjn/9NbTzFgQHKLiXiotTpg= X-Google-Smtp-Source: ABdhPJwjVH2NUJFDO6XXN22+20QVp8wTW8fTlzJBlliCsFi/9xAQRGZJIVZQp+s227oAVYZt0BCEDA== X-Received: by 2002:ac2:58d0:: with SMTP id u16mr2177244lfo.114.1589969301709; Wed, 20 May 2020 03:08:21 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id m10sm956655lfd.15.2020.05.20.03.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 03:08:21 -0700 (PDT) Date: Wed, 20 May 2020 13:08:20 +0300 From: Dmitry Kozlyuk To: Fady Bader Cc: dev@dpdk.org, thomas@monjalon.net, talshn@mellanox.com, yohadt@mellanox.com, olivier.matz@6wind.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anand.rawat@intel.com, ranjit.menon@intel.com Message-ID: <20200520130820.408649f1@sovereign> In-Reply-To: <20200520093444.14904-1-fady@mellanox.com> References: <20200520093444.14904-1-fady@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 20 May 2020 12:34:44 +0300 Fady Bader wrote: > Exported per_lcore__rte_errno function to compile ring for windows. > > compilation error logs: > librte_ring_rte_ring.c.obj : error LNK2019: unresolved > external symbol per_lcore__rte_errno referenced in > function rte_ring_lookup > > The cause was that per_lcore__rte_errno function wasn't included > in the export list. > To solve this per_lcore__rte_errno was added to the Windows export > list. > > Signed-off-by: Fady Bader > Depends-on: series-9374 ("Windows basic memory management") > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/rte_eal_version.map | 5 ++++- > lib/meson.build | 2 +- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/rte_eal_exports.def > b/lib/librte_eal/rte_eal_exports.def index 854b83bcd..cbb6b8cfe 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -1,5 +1,6 @@ > EXPORTS > __rte_panic > + per_lcore__rte_errno > rte_calloc > rte_calloc_socket > rte_eal_get_configuration > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map index bdd014638..1a1dedcd9 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -390,4 +390,7 @@ EXPERIMENTAL { > rte_trace_point_lookup; > rte_trace_regexp; > rte_trace_save; > -}; > + > + # added in 20.08 > + __emutls_v.per_lcore__rte_errno; > +}; > \ No newline at end of file No newline at end of file. > diff --git a/lib/meson.build b/lib/meson.build > index d190d84ef..5b644f5cd 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -36,7 +36,7 @@ libraries = [ > 'flow_classify', 'bpf', 'graph', 'node'] > > if is_windows > - libraries = ['kvargs','eal'] # only supported libraries for > windows > + libraries = ['kvargs','eal','ring'] # only supported Please always place spaces after commas. And IMO, it's time to start breaking this list into lines as the common list above it does. > libraries for windows endif > > default_cflags = machine_args -- Dmitry Kozlyuk