From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21884A0093; Wed, 20 May 2020 15:59:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88B9E1D638; Wed, 20 May 2020 15:58:57 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 79D811D60D; Wed, 20 May 2020 15:58:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 706D01219; Wed, 20 May 2020 09:58:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=jB2OjYGfjEPIS l8t7iJKdVj1gLeBWNA94kkySggoloo=; b=KvLRodqvbPncFe2YZ/2k80dJ8zUmu V+OBLzzQEQIyWIDxRiRhHJ/s9djAEIoLLofhBbUTFOhZ3uJCfLYExXs/5yDOEr0e C7cqP7tRHdNw7rilCxT0PcTTNW1zMgb7LiwgZFp8QARYPePJppqRKQVxH36B1rNN de9mVsNuMh7VPnKcBp52UlIcCcNgyuUu6rsRq/lNmS5EHhknNpWK3vr55jWQPL6q b01SCMHhfJqWf5eaj2ilHi9efSS8WOgWeB+DRkokB11GP/D3Vh5EZHlAoPOlu/3b EtFvLZorMnGx76xbSbjAVINDUlUVA3gjPv0VUJuXDA8yj6eOXCwnr75Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=jB2OjYGfjEPISl8t7iJKdVj1gLeBWNA94kkySggoloo=; b=f+xmweyO KAPngd0bp/RIqk6gtWNFytV3uqkZaeoGCd+U6AimzuYFRSnY10qBAbQ3fiFpCmHc mNMzR7RnSzNVB54HUs5ZPaOf00fwkWX0ZSHn/kz/NZOaormbpPpfKzUbiblqDkb0 YKhKolhhTkKX+B1AmXd/2B/caqtEjl9JvUQOXSOksxxiv5j7BZm5mVIle7TM0q3H 2NGZpKHFNWKvZHV45m3vp0Mb9UD7weffauF3rCXiX6JHcbfwawQxspOMYhfUJn2y 6np37egIJYbqqx4pZTCqh8EKf4jCH/gbIqwUdxHYk6UAgG0SUfTJrw+aahWiwAyT yg7mBYeZh+EHBA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37DF33066451; Wed, 20 May 2020 09:58:52 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, stable@dpdk.org, David Hunt , Bruce Richardson Date: Wed, 20 May 2020 15:58:29 +0200 Message-Id: <20200520135830.1178242-4-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 3/4] examples/vm_power: drop Unix path limit redefinition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Unix socket path may be as long as UNIX_PATH_MAX. This constant is supposed to be defined in sys/un.h. On Linux, it appears to be in linux/un.h. This constant was re-defined locally, based on a variable declaration. It is breaking compilation with -fno-common (default in GCC 10) We could avoid the variable declaration by using NULL struct, but it looks simpler not redefining this system constant. As the power library and its examples are restricted to Linux only, the Linux header file is directly included. Fixes: 0d74597c1b4f ("examples/vm_power: fix max length of unix socket path") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- examples/vm_power_manager/channel_manager.c | 1 - examples/vm_power_manager/channel_manager.h | 7 +------ examples/vm_power_manager/power_manager.c | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index 4d13697208..74a2a677e8 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -4,7 +4,6 @@ #include #include -#include #include #include #include diff --git a/examples/vm_power_manager/channel_manager.h b/examples/vm_power_manager/channel_manager.h index a2a2f2bba0..e55376fcdb 100644 --- a/examples/vm_power_manager/channel_manager.h +++ b/examples/vm_power_manager/channel_manager.h @@ -10,7 +10,7 @@ extern "C" { #endif #include -#include +#include #include #include @@ -26,11 +26,6 @@ extern "C" { /* FIFO file name template */ #define CHANNEL_MGR_FIFO_PATTERN_NAME "fifo" -#ifndef UNIX_PATH_MAX -struct sockaddr_un _sockaddr_un; -#define UNIX_PATH_MAX sizeof(_sockaddr_un.sun_path) -#endif - #define MAX_CLIENTS 64 #define MAX_VCPUS 20 diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c index 7b4f4b3c4d..cd51d4741f 100644 --- a/examples/vm_power_manager/power_manager.c +++ b/examples/vm_power_manager/power_manager.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include -- 2.26.2