From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFF4AA0093; Wed, 20 May 2020 15:59:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC9111D647; Wed, 20 May 2020 15:58:58 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id E28971D634 for ; Wed, 20 May 2020 15:58:55 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 145A1126A; Wed, 20 May 2020 09:58:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=DlNeW92G6dzcO /xhVqeHah3KL+UA9mdSB+1GtxqVOFM=; b=Z+wVo2nM15xwX93A8fdC1bxE2cxKR 0BNnlzt/5ITvvLwCjfj0kK2xPqGFZbcIYwsioB+yKLmf3L5NYmSAWvB59hPXOEcu zKh6SXTqcFj+ggHnraqJ8XlNf/hIHTve1yfZqEcNKulIF7PPUEnm47Z50Vti7osk 00IprBQ5IhZqVTQdsiSjlLkPHSe/dlCwoOw45LFQ61/xWSHgO03QOalLvrwAb4Yr 1CqUm6am+G0pDo4DLPHzx+Gp48oF+I0WN133Fg2kJvHTePUHjWRqOI8gQiQTYQRd tLLW+uL3FsHviyVQYjT9xfuSzqyvJnY+Ta/GBwsxT8XDzUo/7rlLfpQ4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=DlNeW92G6dzcO/xhVqeHah3KL+UA9mdSB+1GtxqVOFM=; b=zx60IaKJ wZ49al91uR/PObcu4NKVpPy6jrSD1rNc0+FI6mgIHelLVsihi0ugEOFKcyruarmX hKdhgU3IVgSgvvdSw5hqir2L5Rjcve3ZZv8VoIo18nxzAWDs4VgTpcZulmu5q4VR g13+FkeEIfKOHA5GQ8oBkwpRfuzagQ1ledWSlSA8xbqRUCW0HLZT766aZruAXsxd oAGL7S+bHFSm3MaYrcoGQCNbxQ9C1iIdEyTZi4x+nacimSQ8WqTefYaHfQqEWu0H UmsHSX1Ql24jneufVJMz4Tzcrgfh65Y2A+EMz/ItD+4Nv6EcWQkBOOxjUuHfCXxw zEy5cciN5Wg0Ww== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvhefgiedvjeegtdevhe efhfetleefgfeivefgffevfeejgedtgfeutdehtdegveenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DCF53066451; Wed, 20 May 2020 09:58:54 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com Date: Wed, 20 May 2020 15:58:30 +0200 Message-Id: <20200520135830.1178242-5-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 4/4] devtools: allow warnings in ABI reference build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no point in forcing warning-free compilation when building an ABI reference. It is only preventing from compiling ABI reference of old releases with recent compilers. Note: DPDK 20.02 is built (with warnings) by GCC 10 if using -fcommon. Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 6 ++---- devtools/test-meson-builds.sh | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 6e53f86fc8..f013656024 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -68,8 +68,6 @@ J=$DPDK_MAKE_JOBS builds_dir=${DPDK_BUILD_TEST_DIR:-.} short=false unset verbose -# for ABI checks, we need debuginfo -test_cflags="-Wfatal-errors -g" while getopts hj:sv ARG ; do case $ARG in j ) J=$OPTARG ;; @@ -248,7 +246,7 @@ for conf in $configs ; do config $dir $target $options echo "================== Build $conf" - ${MAKE} -j$J EXTRA_CFLAGS="$test_cflags $DPDK_DEP_CFLAGS" \ + ${MAKE} -j$J EXTRA_CFLAGS="-Wfatal-errors -g $DPDK_DEP_CFLAGS" \ EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir ! $short || break export RTE_TARGET=$target @@ -282,7 +280,7 @@ for conf in $configs ; do echo -n "================== Build $conf " echo "($DPDK_ABI_REF_VERSION)" ${MAKE} -j$J \ - EXTRA_CFLAGS="$test_cflags $DPDK_DEP_CFLAGS" \ + EXTRA_CFLAGS="-Wno-error -g $DPDK_DEP_CFLAGS" \ EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ O=$abirefdir/build export RTE_TARGET=$target diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index e8df017596..18b874fac5 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -74,7 +74,6 @@ config () # return fi options= - options="$options --werror" if echo $* | grep -qw -- '--default-library=shared' ; then options="$options -Dexamples=all" else @@ -127,7 +126,7 @@ build () # # skip build if compiler not available command -v ${CC##* } >/dev/null 2>&1 || return 0 load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $* + config $srcdir $builds_dir/$targetdir --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" ]; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION -- 2.26.2