From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96653A0093; Thu, 21 May 2020 02:31:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B1581C211; Thu, 21 May 2020 02:31:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 64D601C1FB for ; Thu, 21 May 2020 02:31:27 +0200 (CEST) IronPort-SDR: rNkwaJjAuR9S0djrgdUJPm2PvmVWmd7r4sKvwpEEVl4IajYQgw2uYSMk4/MNwW5CUewuk2Dm4O eVTsoAG6nkEA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 17:31:26 -0700 IronPort-SDR: FuwiSnAOCmet/kFpAWK4MFcBLgin95bJrePzBnr5Kk2SFAUVZZGCx8KkoFi3CtrOnl+1GaXU11 92/1fVb6uWzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,415,1583222400"; d="scan'208";a="440243817" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by orsmga005.jf.intel.com with ESMTP; 20 May 2020 17:31:24 -0700 Date: Thu, 21 May 2020 08:22:47 +0800 From: Ye Xiaolong To: Jeff Guo Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, jianbo.liu@linaro.org, xiaoping.yan@nokia-sbell.com, dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20200521002247.GC99392@intel.com> References: <20200520212521.34197-1-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520212521.34197-1-jia.guo@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] net/i40e: fix error setting for L2TAG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/20, Jeff Guo wrote: >Base on HW, if a packet be split into multiple segments, the L2TAG >should only be valid on the last Rx descriptor. So fix it by setting >L2TAG into mbuf when processing the last split packet. > >Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver") > >Signed-off-by: Jeff Guo >--- > drivers/net/i40e/i40e_rxtx_vec_common.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h >index 0e6ffa007..31f73f605 100644 >--- a/drivers/net/i40e/i40e_rxtx_vec_common.h >+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h >@@ -33,6 +33,7 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs, > if (!split_flags[buf_idx]) { > /* it's the last packet of the set */ > start->hash = end->hash; >+ start->vlan_tci = end->vlan_tci; > start->ol_flags = end->ol_flags; > /* we need to strip crc for the whole packet */ > start->pkt_len -= rxq->crc_len; >-- >2.20.1 > Applied to dpdk-next-net-intel, Thanks.