From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59170A0093; Thu, 21 May 2020 16:49:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 595C91D6EA; Thu, 21 May 2020 16:49:01 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 81D361D6D7; Thu, 21 May 2020 16:48:58 +0200 (CEST) IronPort-SDR: 1OlNbO9h9lF9u/fiZ+GQT7z66GN701Sux0fzjAa5zerR5fb65fB/FOiNeLkyBaAEThI0dOIYpl sZVRhR4mJzKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 07:48:57 -0700 IronPort-SDR: IlbuIN6tzcU6hP0t66WolYAM5YSR55bZHT2TljZi+hvLjcFkS1QmnOe2U9K125aNjySOEfByDS e0QaQT7Rl+rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,418,1583222400"; d="scan'208";a="374444743" Received: from adamdybx-mobl.ger.corp.intel.com (HELO addy-VirtualBox.ger.corp.intel.com) ([10.104.121.10]) by fmsmga001.fm.intel.com with ESMTP; 21 May 2020 07:48:56 -0700 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com Cc: stable@dpdk.org, Adam Dybkowski Date: Thu, 21 May 2020 16:48:53 +0200 Message-Id: <20200521144853.4680-2-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200521144853.4680-1-adamx.dybkowski@intel.com> References: <20200521113817.3148-1-adamx.dybkowski@intel.com> <20200521144853.4680-1-adamx.dybkowski@intel.com> Subject: [dpdk-dev] [PATCH v4 1/1] cryptodev: fix SHA-1 digest enum comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: stable@dpdk.org Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe Acked-by: Anoob Joseph --- lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index d9585ecd6..da961a19d 100644 --- a/lib/librte_cryptodev/rte_crypto_sym.h +++ b/lib/librte_cryptodev/rte_crypto_sym.h @@ -269,9 +269,12 @@ enum rte_crypto_auth_algorithm { /**< HMAC using MD5 algorithm */ RTE_CRYPTO_AUTH_SHA1, - /**< 128 bit SHA algorithm. */ + /**< 160 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA1_HMAC, - /**< HMAC using 128 bit SHA algorithm. */ + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting + * digest_length to 12 bytes in auth/aead xforms. + */ RTE_CRYPTO_AUTH_SHA224, /**< 224 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA224_HMAC, -- 2.17.1