From: Guinan Sun <guinanx.sun@intel.com>
To: dev@dpdk.org
Cc: Zhao1 Wei <wei.zhao1@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Guinan Sun <guinanx.sun@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix flow control status get
Date: Sat, 23 May 2020 05:22:39 +0000 [thread overview]
Message-ID: <20200523052239.62928-3-guinanx.sun@intel.com> (raw)
In-Reply-To: <20200523052239.62928-1-guinanx.sun@intel.com>
mac_ctrl_frame_fwd assignment is missing, so
setting mac_ctrl_frame_fwd should be added in
ixgbe_flow_ctrl_get().
The patch fixes the issue.
Fixes: 56ea46a997b7 ("ethdev: retrieve flow control configuration")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
v2 changes:
* Set fc mac_ctrl_frame_fwd by bit operation.
* Modified commit messge.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 42947ba40..890d756e4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4752,6 +4752,11 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
* MFLCN register.
*/
mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
+ if (mflcn_reg & IXGBE_MFLCN_PMCF)
+ fc_conf->mac_ctrl_frame_fwd = 1;
+ else
+ fc_conf->mac_ctrl_frame_fwd = 0;
+
if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
rx_pause = 1;
else
--
2.17.1
next prev parent reply other threads:[~2020-05-23 5:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 6:12 [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter Guinan Sun
2020-05-22 7:46 ` Yang, Qiming
2020-05-22 9:42 ` Zhao1, Wei
2020-05-22 9:46 ` Zhao1, Wei
2020-05-23 2:35 ` Sun, GuinanX
2020-05-23 5:22 ` [dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get Guinan Sun
2020-05-23 5:22 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix incorrect MAC control frame forward Guinan Sun
2020-05-23 5:22 ` Guinan Sun [this message]
2020-06-02 10:54 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix flow control status get Jiang, YuX
2020-05-23 9:43 ` [dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get Zhao1, Wei
2020-07-20 9:56 ` Zhao1, Wei
2020-07-20 10:42 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523052239.62928-3-guinanx.sun@intel.com \
--to=guinanx.sun@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).