DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: fix epoll fd list rebuild
@ 2020-05-11 13:43 Harman Kalra
  2020-05-24 15:30 ` Thomas Monjalon
  0 siblings, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-05-11 13:43 UTC (permalink / raw)
  To: stephen, jgrajcia, david.marchand; +Cc: dev, Harman Kalra, stable

An issue has been observed where epoll file descriptor
list rebuilds every time an interrupt/alarm event is
received.

eal_intr_process_interrupts() should notify pipe fd only
if any source is removed from the source list i.e (rv > 0)

Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
Cc: stable@dpdk.org

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 lib/librte_eal/linux/eal_interrupts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c
index 16e7a7d51..84eeaa1bc 100644
--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c
@@ -1010,7 +1010,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds)
 		}
 
 		/* notify the pipe fd waited by epoll_wait to rebuild the wait list */
-		if (rv >= 0 && write(intr_pipe.writefd, "1", 1) < 0) {
+		if (rv > 0 && write(intr_pipe.writefd, "1", 1) < 0) {
 			rte_spinlock_unlock(&intr_lock);
 			return -EPIPE;
 		}
-- 
2.18.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-06-24  8:01 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 13:43 [dpdk-dev] [PATCH] eal: fix epoll fd list rebuild Harman Kalra
2020-05-24 15:30 ` Thomas Monjalon
2020-05-25  9:49   ` [dpdk-dev] [EXT] " Harman Kalra
2020-05-27 12:32     ` Harman Kalra
2020-05-27 12:44       ` Harman Kalra
2020-05-27 13:04         ` Thomas Monjalon
2020-05-27 17:19           ` Harman Kalra
2020-06-19 13:59   ` [dpdk-dev] [PATCH v2] " Harman Kalra
2020-06-24  8:01     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).