From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F02CCA04EF; Mon, 25 May 2020 11:53:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAC611D37F; Mon, 25 May 2020 11:53:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A56BC1C190 for ; Mon, 25 May 2020 11:53:33 +0200 (CEST) IronPort-SDR: KYZ7KsfsN3aqXiySmYTEph58xoHA5UU8L4G2NVmpjUKm2X0gjFiFq2ty2LdPc30bXo7leWKNd1 rQeR3MNQmAkA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 02:53:32 -0700 IronPort-SDR: qSSrusNvq6q6aUsoaudpT3mBEU7EbCLybxcPe6R40fuco4vA9a2efuFwgbvpQC3ZYhVu9xbqLz dGAakdOnh6mQ== X-IronPort-AV: E=Sophos;i="5.73,433,1583222400"; d="scan'208";a="413462971" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.22.226]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 May 2020 02:53:31 -0700 Date: Mon, 25 May 2020 10:53:28 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: "Kilheeney, Louise" , "dev@dpdk.org" Message-ID: <20200525095328.GC891@bricha3-MOBL.ger.corp.intel.com> References: <20200522132320.26373-1-louise.kilheeney@intel.com> <4878977.pQFTBNOIfY@thomas> <2851145.1dIjF4ch0v@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2851145.1dIjF4ch0v@thomas> Subject: Re: [dpdk-dev] [PATCH 20.08 9/9] config/arm: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, May 23, 2020 at 11:27:42PM +0200, Thomas Monjalon wrote: > 22/05/2020 16:10, Kilheeney, Louise: > > From: Thomas Monjalon > > > 22/05/2020 15:23, Louise Kilheeney: > > > > Changed script to explicitly use python3 only. > > > > > > What is the reason of this change? > > > > since python 2 is EOL, Making these scripts to use python3-only, > > it's part of a general update to have everything use python3. > > This is already using python 3 and this makes it explicit. > > This is to avoid maintaining python 2 compatibility I guess. > Please insert this real reason in the git commit log. > Also, python 2 may not be installed (unless explicitly requested) on modern distro releases. My Ubuntu 20.04 still only had a "python3" binary, no "python" binary. > > > > --- a/config/arm/armv8_machine.py > > > +++ b/config/arm/armv8_machine.py > > > @@ -1,4 +1,4 @@ > > > -#!/usr/bin/python > > > +#!/usr/bin/python3 > > Are you sure all OS have /usr/bin/python3? > Is it called "python" sometimes? > Is it always located in /usr/bin/? > Shouldn't we use "#! /usr/bin/env python3" ? > Good catch. +1 for this. On BSD python is in /usr/local/bin