From: Fady Bader <fady@mellanox.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, talshn@mellanox.com, yohadt@mellanox.com,
olivier.matz@6wind.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com, anand.rawat@intel.com,
ranjit.menon@intel.com, dmitry.kozliuk@gmail.com
Subject: [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows
Date: Wed, 27 May 2020 11:24:25 +0300 [thread overview]
Message-ID: <20200527082425.8188-1-fady@mellanox.com> (raw)
In-Reply-To: <'20200520093444.14904-1-fady@mellanox.com'>
Exported per_lcore__rte_errno function to compile ring for windows.
compilation error logs:
librte_ring_rte_ring.c.obj : error LNK2019: unresolved
external symbol per_lcore__rte_errno referenced in
function rte_ring_lookup
The cause was that per_lcore__rte_errno function wasn't included
in the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.
Signed-off-by: Fady Bader <fady@mellanox.com>
---
Depends-on: series-9374 ("Windows basic memory management")
v4: rebase on "Windows basic memory management" v5.
v3: Fix style issues.
v2: Fix style issues.
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/rte_eal_version.map | 1 +
lib/meson.build | 6 +++++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 854b83bcd..cbb6b8cfe 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -1,5 +1,6 @@
EXPORTS
__rte_panic
+ per_lcore__rte_errno
rte_calloc
rte_calloc_socket
rte_eal_get_configuration
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index dff51b13d..8937bdfea 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -392,4 +392,5 @@ EXPERIMENTAL {
rte_mem_lock;
rte_mem_map;
rte_mem_unmap;
+ __emutls_v.per_lcore__rte_errno;
};
diff --git a/lib/meson.build b/lib/meson.build
index d190d84ef..30ed9e05e 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -36,7 +36,11 @@ libraries = [
'flow_classify', 'bpf', 'graph', 'node']
if is_windows
- libraries = ['kvargs','eal'] # only supported libraries for windows
+ libraries = [
+ 'kvargs',
+ 'eal',
+ 'ring'
+ ] # only supported libraries for windows
endif
default_cflags = machine_args
--
2.16.1.windows.4
next prev parent reply other threads:[~2020-05-27 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <'20200520093444.14904-1-fady@mellanox.com'>
2020-05-21 14:14 ` [dpdk-dev] [PATCH v3] " Fady Bader
2020-05-27 8:24 ` Fady Bader [this message]
2020-05-27 20:59 ` [dpdk-dev] [PATCH v4] " Ranjit Menon
2020-06-21 12:06 ` [dpdk-dev] [PATCH v5] " Fady Bader
2020-06-29 23:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527082425.8188-1-fady@mellanox.com \
--to=fady@mellanox.com \
--cc=anand.rawat@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).