From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70C2FA00BE; Wed, 27 May 2020 22:59:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 102AF1DAFA; Wed, 27 May 2020 22:59:20 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by dpdk.org (Postfix) with ESMTP id 723581DAF9 for ; Wed, 27 May 2020 22:59:18 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id k2so1091960pjs.2 for ; Wed, 27 May 2020 13:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=suTPDzx9V6zRmiKMf4/h5sOWz/1oWgIMES+9JK8guNo=; b=bsFWbcyFU7jRWsWy8RPQTlSLieFKIZyI5aDXKT4ImDqLV0dtKky8l/dpIow1Ma0lXC Ka/S8qzsEG00aQAqyk3JhBCJFhC+4BCHyQxS7bihEYOlEnAOEBc5BjaIGu1OvNfeu26l azcjI1105PPEcPIgsl+Rx2PRS+Cse8Q+bTZPasyRLkPYivNxr9fA6Cju1cLz+CejC9/i vKyC2m9nIqywCe9u6TultwBRvCT8scRczUpaJbX+ZLJW5w2o8xfsPkvZXCfmiiKQD5el t/DXgCq8dwtYk/QW218w52By8kPeDe2oSA4LlCOj6s2kZGbB5M8Dfr70fmRKM2mTiA2e z5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=suTPDzx9V6zRmiKMf4/h5sOWz/1oWgIMES+9JK8guNo=; b=IEU3Mtjq6zHuO0vzsUxPUtx106c4ZyLAokiFNicjcJRzXwnSEKKmqUQS542mNrXDom OUiU2gyHxbiokpB6PuJ3dX4jXEuzyOu9jbDaLpwrxrk7p9O7lxn9zBZMYYngOzUZMXVS 9bFaan7lGotOMD5uhMZDTmCOhzKlxtyWWBBP7JWH6hJxWqaRrSaW1NLAPbgoGrXdqsTV UqUAs7YgtKimbqvTectPt03sC/4/vYddU4ntZIaIJUfnoGYrwcVb6+XKp6+DqyZM9QTv 7Q7q4fBZPoDklxdbSzQDeTZjRrfwd8MzHlvvE7IkdzHSvJHlmwx7ncyn9XI2lgImgCTf j9Wg== X-Gm-Message-State: AOAM531vBA8XMfHI/bKTz+8fWepaPKnOZd1OMz/DnSyxijySq2zDyPzN XF4n4J+3ZHHNEVOB4J4CJuDRsxNGfmBWkg== X-Google-Smtp-Source: ABdhPJyDxqoutC+jRu1f5x3twHpqkCwSfE8aW4w/cCtSevOsccRUVlXnzhUIuntRyhCFhQ2f4IGndQ== X-Received: by 2002:a17:90a:aa8d:: with SMTP id l13mr270795pjq.92.1590613157387; Wed, 27 May 2020 13:59:17 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q44sm3709227pja.2.2020.05.27.13.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 13:59:17 -0700 (PDT) Date: Wed, 27 May 2020 13:59:14 -0700 From: Stephen Hemminger To: Muhammad Bilal Cc: dev@dpdk.org Message-ID: <20200527135914.05e624ff@hermes.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 28 May 2020 01:13:27 +0500 Muhammad Bilal wrote: > Recently I have submitted patches and some tests were failing on patchwork. > My question is, which tests are compulsory to pass for a patch to be accepted. > As in the below mentioned patch, it is accepted while 1 test was still failing. > http://patches.dpdk.org/patch/70348/ > > kind regards. > Muhammad Bilal There are two different issues: 1. A patch should not get blamed for some failure in the CI infrastructure. Or collataral damage from an earlier merge. 2. A patch must not introduce a failure. I.e. if all tests passed before each patch in a patchset must pass.