From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7368A00BE; Thu, 28 May 2020 00:02:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 533771DB11; Thu, 28 May 2020 00:02:38 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id AB1921DB11 for ; Thu, 28 May 2020 00:02:36 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id u5so12460547pgn.5 for ; Wed, 27 May 2020 15:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hFxGaJHUL+7BW3IvBPLGSyBk6YL/7uXR564Tm70zQNA=; b=EnaXOjcnXUMw5JSyYx2uicJoSHF+vLXweD47Ym4hpzjr2KC9imGNUlNyXB+Q3UGhBE iluH9H5CUhkXevEZrFYaE/dkONaNqHWAAZ69pEXbG+GTHXU2uwmfhrkG9otWufXbNZCP ERMu/Yv1jrVgDunRAz/Kdb2yfNNNg0X5f1X47Af+n9navqFIDdlaY8Evmlrle+5jX2yo AXXNmpFD3wHxb8jIhqY+7mfAyRgkQt0fzref0SojG+JqMqrf+lrdMO+8txk/4qnWl27i 0CBaSwa5hkXnEGqnwaOcM88ZHiHl3P8kLkstUr4NlMjuHmh0+l/xGpO54hifx/uuXvo7 ZVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hFxGaJHUL+7BW3IvBPLGSyBk6YL/7uXR564Tm70zQNA=; b=igB3Gb/KMUljCUqwcPrsFPYk1PlnJV7U3WpvGxRZYBp0XH/bLNp75mB6CA3bF1Yll8 AbqjMKL2UfyDAPFGMkp3YUJ2ij7UmVtNdEOOVYMazrdqJOSLSYrrzfmk8yniZk2blebk aIZxs1oISYt3oVlfguuAkn/YbrZxV7gqufPi4HJDGA+1W467ieRSFIEY26xu91TpxsSK olXxS2TgHf8gv6qvFEhQnrcKIZIErV1VSMwM4i9iJDkX8OG87VqetoxwiG5zI7msn3Dl K4xgBG9P+2hTzAXWsKhro2fpYkDtgfRt1JxA4nqXuq18jQBf611fWGIIW6dIcIEToPkB +64g== X-Gm-Message-State: AOAM5301hx+hbVCSItL+5M/ffedo8TQR1/z708pY+VSgJB5aIQYb76H9 Qx/AIrXlGgU2XKOl5AikYYxOcQ== X-Google-Smtp-Source: ABdhPJxSODSfnhR67azvVt6xZzfiTUlJziGgAz0wjAKMdLc9POblZrdP2QCGYIyWzSalHF9qf3Gafg== X-Received: by 2002:a05:6a00:843:: with SMTP id q3mr5799386pfk.107.1590616955736; Wed, 27 May 2020 15:02:35 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t2sm2806326pgh.89.2020.05.27.15.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 15:02:35 -0700 (PDT) Date: Wed, 27 May 2020 15:02:32 -0700 From: Stephen Hemminger To: =?UTF-8?B?R2HDq3Rhbg==?= Rivet Cc: Andrew Rybchenko , dev@dpdk.org, Ian Dolzhansky , Stephen Hemminger , stable@dpdk.org Message-ID: <20200527150232.687b197f@hermes.lan> In-Reply-To: <20200527213525.euhc2dlilnypmzg5@u256.net> References: <1590590073-8964-1-git-send-email-arybchenko@solarflare.com> <20200527150711.4geagdtf2f5ipjk5@u256.net> <20200527213525.euhc2dlilnypmzg5@u256.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 27 May 2020 23:35:25 +0200 Ga=C3=ABtan Rivet wrote: > On 27/05/20 18:30 +0300, Andrew Rybchenko wrote: > > On 5/27/20 6:07 PM, Ga=C3=ABtan Rivet wrote: =20 > > > On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: =20 > > >> From: Ian Dolzhansky > > >> > > >> Failsafe driver has been indicating zero for RSS redirection table s= ize > > >> after device info reporting had been reworked. Report proper value. > > >> > > >> Fixes: 4586be3743d4 ("net/failsafe: fix reported device info") > > >> Cc: Stephen Hemminger > > >> Cc: stable@dpdk.org > > >> > > >> Signed-off-by: Ian Dolzhansky > > >> Signed-off-by: Andrew Rybchenko > > >> --- > > >> drivers/net/failsafe/failsafe_ops.c | 8 ++++++++ > > >> 1 file changed, 8 insertions(+) > > >> > > >> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/fails= afe/failsafe_ops.c > > >> index e046cfe6aa..45da9378c3 100644 > > >> --- a/drivers/net/failsafe/failsafe_ops.c > > >> +++ b/drivers/net/failsafe/failsafe_ops.c > > >> @@ -1068,6 +1068,13 @@ fs_dev_merge_info(struct rte_eth_dev_info *in= fo, > > >> info->rx_queue_offload_capa &=3D sinfo->rx_queue_offload_capa; > > >> info->tx_queue_offload_capa &=3D sinfo->tx_queue_offload_capa; > > >> info->flow_type_rss_offloads &=3D sinfo->flow_type_rss_offloads; > > >> + > > >> + /* > > >> + * RETA size is a GCD of RETA sizes indicated by sub-devices. > > >> + * Each of these sizes is a power of 2, so use the lower one. > > >> + */ > > >> + info->reta_size =3D RTE_MIN(info->reta_size, sinfo->reta_size); > > >> + > > >> info->hash_key_size =3D RTE_MIN(info->hash_key_size, > > >> sinfo->hash_key_size); > > >> =20 > > >> @@ -1128,6 +1135,7 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > > >> infos->max_hash_mac_addrs =3D UINT32_MAX; > > >> infos->max_vfs =3D UINT16_MAX; > > >> infos->max_vmdq_pools =3D UINT16_MAX; > > >> + infos->reta_size =3D UINT16_MAX; > > >> infos->hash_key_size =3D UINT8_MAX; > > >> =20 > > >> /* > > >> --=20 > > >> 2.17.1 > > >> =20 > > >=20 > > > Hello Andrew, Ian, > > >=20 > > > The reta_size info is linked to being able to update the RSS RETA. > > >=20 > > > I don't think it is a bug for the moment to report 0, as long as > > > failsafe does not support RETA update. Now, the reta_update ops could= be > > > quickly implemented in failsafe, but that should be a new feature. > > >=20 > > > Did you hit an issue with it? =20 > >=20 > > Hello Gaetan, > >=20 > > in our case reta_size is required for RSS testing even if there > > is no reta update and query API to estimate where a packet > > should be delivered. It assumes that default reta spreads over > > all Rx queue evenly. I.e. we need reta size and number of Rx > > queues to built default reta. > >=20 > > May be it is really very testing specific, but IMO logical > > anyway. > >=20 > > Andrew. =20 >=20 > Alright, given the size of the change there is no reason not to add it > if it can improve consistency. >=20 > I think the patch is fine otherwise, I'm just not sure it should be > marked as a bug fix, but backporting won't be hard. >=20 > Thanks, >=20 > Acked-by: Gaetan Rivet >=20 Agreed, looks good to me, but probably doesn't matter much. Almost all hard= ware only supports one reta_size anyway. Acked-by: Stephen Hemminger