From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B77AA00BE; Wed, 27 May 2020 18:34:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07F261D9AA; Wed, 27 May 2020 18:34:41 +0200 (CEST) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 0947E1D982 for ; Wed, 27 May 2020 18:34:40 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id a25so18087712ljp.3 for ; Wed, 27 May 2020 09:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1Fpp+ZTLFfdGDeTHWAoDl96nNdfnAWByFvYP2GrNmzQ=; b=ELwQW/vhMk8K46CAF2ak/+6XtFxl+uYNPJmoysNmsraPHpwP9hY1kAVKpjRMpo+De1 /wIsEOMnOHqV+pzc+vA2P77xbt1EfrXdHsIaDEKdqAp9isfnwNHaJiinZCwsM08fRq+R 7KUypKv20rgPOORaGEOXOpIVzhvi3NRl0MpTp8cSgydq0zIL3YTAbUUiSWIFOy9YZhns Wf7tQlp3uRp+We+JNt1IpUvUeGA3IDsehaICQ4SfMotLCuaByVaPfk8s0r8VA4fSJlY3 myktUn4G/XC9snU1iZEWSJpcXmJJEjg43EHRRE5oONHK4Zn61edVlFYmlaRlaUWrpsLd fL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1Fpp+ZTLFfdGDeTHWAoDl96nNdfnAWByFvYP2GrNmzQ=; b=LDwUGLWch+uZYTqj8hOdksjMjYxV3sv1aV730dl4EEAYwiYhHAaoGqj2ZWkTOWpt5d vr0mUcB1erTrUjOcr1ZLKnAMwALXZYyHeIQ43XG0FUyGFO3eBxiNZfaNZMqPkDNibUEl b4lj1h9gNDuDZOL4bPiOYuG2fiXL92leKM3VV5bSu6cwIkaDFHMbH7MYAwc9pYVasylE r8CNYL9LLgYL77xtU4PhkSVN9dOSw8muTYQMkDs8piLjuTYjAYXtFkaoO7dcQGcJv+q+ /JAiRWDVkhU8XgkAjlIRlgvX8ehU7VAIeqRr+M39TegqjJ6OJ9Ghl+iTxoYS+QJ/xyTc wsqg== X-Gm-Message-State: AOAM533FLqKe61oC3k3LpZ+KYUIyhww9yPryV4VU2KqomzxogSIsPR84 A1ereeVtlUfD0s872e/6LWQ= X-Google-Smtp-Source: ABdhPJzBSnq3Yn2tghhsLEJ+WidySoafu5RJRwB7d6vDF98QCIkRPwHrtcn5rvZyUlwGNzQDN4lkeA== X-Received: by 2002:a2e:81c7:: with SMTP id s7mr3301526ljg.203.1590597279565; Wed, 27 May 2020 09:34:39 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id w25sm905487lfn.42.2020.05.27.09.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 09:34:38 -0700 (PDT) Date: Wed, 27 May 2020 19:34:37 +0300 From: Dmitry Kozlyuk To: Ray Kinsella Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson , Neil Horman Message-ID: <20200527193437.4ced095d@sovereign> In-Reply-To: <5596a817-0913-377c-66cb-3dbf5a24ed66@ashroe.eu> References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-4-dmitry.kozliuk@gmail.com> <5596a817-0913-377c-66cb-3dbf5a24ed66@ashroe.eu> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 03/11] eal: introduce memory management wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Answers below is the summary of discussion with Thomas, Ranjit, Tal, et al. On Wed, 27 May 2020 07:33:32 +0100 Ray Kinsella wrote: > Are wrappers 100% are required. > Would it be simpler (and less invasive) to have a windows_compat.h that plugged this holes? > I am not sure on the standard approach here - so I will leave this to others. With wrappers, we control API and semantics, which is limited compared to the underlying syscalls. It is also cleaner not to export non-RTE symbols from DPDK libraries. Regarding invasion: it requires little change, factoring out some common error logging in the process. > Outside of that - do these symbols really require experimental status. > Are they really likely to change? Indeed, the wrappers should be internal, not experimental. Will fix in v6. -- Dmitry Kozlyuk