From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB834A00BE; Thu, 28 May 2020 04:22:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524511DA22; Thu, 28 May 2020 04:22:31 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 62B0E1DA10 for ; Thu, 28 May 2020 04:22:28 +0200 (CEST) IronPort-SDR: FKcUfs00ubA8/VR1U0wEoH4BhBiTyloVR/M9cRVbQxzdx35VmHU5hAUG04KA9TFEwbY3XvUxzQ ZM6XA+FHwLRg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 19:22:27 -0700 IronPort-SDR: v1hwLvfeOiQUhNOHqZKEHrRtP+T/DViPvCm34ctpbWKQEypzb9+9TmbPOTKV7gbnowCgSy4pCx mNL9UzodyS3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,443,1583222400"; d="scan'208";a="285014946" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by orsmga002.jf.intel.com with ESMTP; 27 May 2020 19:22:22 -0700 Date: Thu, 28 May 2020 10:14:18 +0800 From: Ye Xiaolong To: Jeff Guo Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, dev@dpdk.org Message-ID: <20200528021418.GA75561@intel.com> References: <20200527071650.82645-1-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527071650.82645-1-jia.guo@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] net/iavf: fix flow uninit issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/27, Jeff Guo wrote: >When closing VF device, the process of shutdown adminq should be after of >the process of uninit the flow, since the VF might be still use the adminq >to uninit flow. > >Fixes: 9e03acd726cf ("net/iavf: fix flow access") >Fixes: ff2d0c345c3b ("net/iavf: support generic flow API") >Signed-off-by: Jeff Guo >--- > drivers/net/iavf/iavf_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c >index e09efffd1..2b1066b0a 100644 >--- a/drivers/net/iavf/iavf_ethdev.c >+++ b/drivers/net/iavf/iavf_ethdev.c >@@ -1432,6 +1432,7 @@ iavf_dev_close(struct rte_eth_dev *dev) > > iavf_dev_stop(dev); > iavf_flow_flush(dev, NULL); >+ iavf_flow_uninit(adapter); > iavf_shutdown_adminq(hw); > /* disable uio intr before callback unregister */ > rte_intr_disable(intr_handle); >@@ -1440,8 +1441,6 @@ iavf_dev_close(struct rte_eth_dev *dev) > rte_intr_callback_unregister(intr_handle, > iavf_dev_interrupt_handler, dev); > iavf_disable_irq0(hw); >- >- iavf_flow_uninit(adapter); > } > > static int >-- >2.20.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.