From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17EEFA00BE; Thu, 28 May 2020 12:09:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACAD11DB80; Thu, 28 May 2020 12:09:26 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id EF02F1DB7E for ; Thu, 28 May 2020 12:09:24 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id 202so16242438lfe.5 for ; Thu, 28 May 2020 03:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1fRovZT63IL4VyVZ6t6Cxkr1M14sz0rl4AOcrhVJ5jU=; b=PqOE/+2UdB/ubbTWtUj8Z81BbfZcfHXTQ97+IL1kpvK/JuTi52LFlrQYP8QFmXkcrM fNtL9DWrOqbu/MLS5pt/J+wk3xar0hZNOx1+S1U+3NFV7MtLdRbDAcsg/jTN8DNEr1o5 p/cdM4t8/6tJ9JqNwsY+S1FxrtX5qZ6vx3C0NG3AxSMVdUS4xfuS7Zeo5qo2fAicMj8A nv9gTNYVkX9ZedF7Y58hmNYPgRd2hZSdAFnaHKynML9wqQpTvBKqrUgje7l4Mw2h56MJ ec/6Tn0R4FsllfMG7Ik+7W7/Udz5lG7yF+mHIN8nxjuBN7hGLXs03dLFYqk+DrtIXtXl szdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1fRovZT63IL4VyVZ6t6Cxkr1M14sz0rl4AOcrhVJ5jU=; b=PDkMqKmjM7Eoz6cOpF0Yrkc16aEudh5MRBZUsk9YKhJHg9Gr2Ch6IvbzBQ6rJdEVhH n/uDxT6vPYp11NyfEiwXBDhGKc6dSWqY7VCNzf+0YZ5MSzulzW5jjAYH/mTdscrH9ugh mYDjcUPst8PDdKwfGZRExLGcvot6U3eBUMMme8v9d61EHD0GDhF1+/JqnA6PF23zuGXO 86vHxaSBU6VLbVPAgVrG44iTdVf0LSKBb16CbDQPH61vew9tMlp7tzXaZt7rc82rr07X qjFsy/L0HIDdiHQHN8KgGkBVeby8ipx3yCk7yt8sRZTLj+SC5YMM/ty7r3FD+b2+BppF BvCw== X-Gm-Message-State: AOAM532iOUgx1Pw8IoTaCmhx5CUY5JmTamtH3D6ixbsp8xbTtsv9qzVr Qvn+Fp4MBaFpC7CvUA0G5qU= X-Google-Smtp-Source: ABdhPJxNd7oHCbEL65Lm/65647o8BbU4cB131+mWjf8r4YoKV4I75ja13z+XiheVfKaQv61kSmLmGA== X-Received: by 2002:a19:f11c:: with SMTP id p28mr1333590lfh.0.1590660564478; Thu, 28 May 2020 03:09:24 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id n2sm1535836lfl.53.2020.05.28.03.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 03:09:23 -0700 (PDT) Date: Thu, 28 May 2020 13:09:22 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson Message-ID: <20200528130922.1606a8b0@sovereign> In-Reply-To: <1739619.a3TOMyy0yD@thomas> References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-3-dmitry.kozliuk@gmail.com> <1739619.a3TOMyy0yD@thomas> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 28 May 2020 09:59:13 +0200 Thomas Monjalon wrote: > 25/05/2020 02:37, Dmitry Kozlyuk: > > * eal_file_lock: lock or unlock an open file. > > * eal_file_truncate: enforce a given size for an open file. > [...] > > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > > which is intended for common code between the two. Files should be named > > after the ones from which the code is factored in OS subdirectory. > [...] > > lib/librte_eal/unix/eal_unix.c | 51 ++++++++++++++++++++++ > > Why naming this file eal_unix? > If it's truly global, it should be unix/eal.c We've already discussed this: Makefiles are written in such way that files in common and arch directories must have distinct names for OS-specific ones. Until Makefiles exist, this is consistent naming with the rest of librte_eal. > If it's only about file operations, it could be unix/eal_file.c Good suggestion, given that more file-related functions are expected to be extracted here in future (e.g. for tracing). > Please update MAINTAINERS when creating a new file. > All files or directories must be listed in MAINTAINERS, > even if there is no maintainer for them. Will do. -- Dmitry Kozlyuk