From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E94EBA00C5; Fri, 29 May 2020 07:48:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91FF61DC0A; Fri, 29 May 2020 07:48:34 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id DFE881DA11 for ; Fri, 29 May 2020 07:48:33 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id d66so725857pfd.6 for ; Thu, 28 May 2020 22:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3jQyOLovwSf4Z73y1nNwtXb3WqY5HvHeTGM/ifjcAMU=; b=u3BQEKaY5qljBVzmqtAKsyOybFoD06b4NZEEKn1ylfKoDGzbynwuT4CEPsjnYxldrx puMwEQgB+E8tpy//jHwOFMO2WLoM8to1qPTox4Lw0WkIzTFbI6krl13x/RuFMuBlwMSN E/IVH6KpqYKIAgMZSwf2nW+cgHHMLZuvjHnLJy6ice5aI43gvKGQ03Q0OgqVdc8OI3og BqcYKdbS0r34glqg/Um0yqLeaL5tjok+swcnRrJcpCCpyGdbXMDPNwBA5hhy8RTOTFow 8fNj+LS62ds6iIfXkbO7PwKx5IYVXhcZi4eiZVuvnJA4rVWcUX0V/yPWtbIu8q+M4W1R rBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3jQyOLovwSf4Z73y1nNwtXb3WqY5HvHeTGM/ifjcAMU=; b=Hx+lpd4sgqzlfcDiOlYXq6JzZq06+3oLY7wUj/XsztmFLLGtQJQ1ZW3vfUL0cxd89E RfYdHlPpCprDsOpQU6l+qMDU5pRwtIspkteeElbFQIPo+ANGrZcDpiEKWqgP8in5ZoAe IHJKWqLcRPSz34NZEKGBrHFbcDjHas/EqWFvG9mLSySlg5L++NySeKcAEvwxS6ZU+Gg6 dpcITQ36/NjsJKFspxTGtcV/WhgueKf6Qo8ixTnVeXCHwlVosZ8eAYWO1cZxMSR88Ab9 X0d6q/C+llv5ewwg5rbVul85pI8vxjey915MM76X5SynIFb866zJ7HWag7yK5aLf3NRR I7Uw== X-Gm-Message-State: AOAM533Wpnjlur4U9Np4aSp+LkF2XmS1DPJtBGcKffyH6UzpQ5Vv7zEd N2lSiQGVNejYaThTcrefhdJ81nFG8zDAJA== X-Google-Smtp-Source: ABdhPJxyNU/boUy67lyNk45bB1+8J97iXSUHiZO0o0dFRylP474qXHati1hWtoSh9zk2MtvZKs54aA== X-Received: by 2002:a62:9256:: with SMTP id o83mr6662482pfd.216.1590731313052; Thu, 28 May 2020 22:48:33 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b11sm6356680pfd.178.2020.05.28.22.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 22:48:32 -0700 (PDT) Date: Thu, 28 May 2020 22:48:30 -0700 From: Stephen Hemminger To: Hrvoje Habjanic Cc: dev@dpdk.org Message-ID: <20200528224830.20181ddd@hermes.lan> In-Reply-To: <20200526172455.6457-1-hrvoje.habjanic@zg.ht.hr> References: <20200526172455.6457-1-hrvoje.habjanic@zg.ht.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 26 May 2020 19:24:55 +0200 Hrvoje Habjanic wrote: > In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, > line 865), there is code to free all allocated stuff related to > scheduler subport. First there are some checks, and in the end, > rte_bitmap_free is called. > > Now, rte_bitmap_free is a dummy function, and it just checks if > provided pointer to bitmap is valid or not. So, actual memory for > subport is not freed. > > This patch fixes this by removing call to rte_bitmap_free, and > instead calling rte_free. > > Signed-off-by: Hrvoje Habjanic Fixes: ce7c4fd7c2ac ("sched: add pipe config to subport level") Acked-by: Stephen Hemminger