From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B89EA00C5; Fri, 29 May 2020 03:20:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B298D1DC09; Fri, 29 May 2020 03:20:04 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C2B071DC06 for ; Fri, 29 May 2020 03:20:03 +0200 (CEST) IronPort-SDR: Vq9dpaFq/dZbb/ecCkKHkLg4lf8FtC4Cfc7LlBLkWNwPSaMhIcCjjxO1DenXQinEPPzjn5U9s1 FVCYpetw7SSw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 18:20:02 -0700 IronPort-SDR: +yxrmrZEXJOll85FGDd8BRcPsjfraPQXudK2B7Vu37DRjrgNaJWWkCMwExg2lBSnHHqjYURtlK OJ4Gh8UUfeVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,446,1583222400"; d="scan'208";a="469334073" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga005.fm.intel.com with ESMTP; 28 May 2020 18:20:01 -0700 Date: Fri, 29 May 2020 09:11:54 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com Message-ID: <20200529011154.GB75561@intel.com> References: <20200528053913.98113-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528053913.98113-1-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/28, Haiyue Wang wrote: >The PCI DSN (device serial number) to format package file name should be >lowercase values. > >Fixes: d1c91179e952 ("net/ice: check DSN package file firstly") > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c >index bdfc7d430..d13e19d78 100644 >--- a/drivers/net/ice/ice_dcf_parent.c >+++ b/drivers/net/ice/ice_dcf_parent.c >@@ -242,13 +242,13 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name) > rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn)); > > snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE, >- ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg", >+ ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg", > (unsigned long long)dsn); > if (!access(pkg_name, 0)) > return 0; > > snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE, >- ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg", >+ ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg", > (unsigned long long)dsn); > if (!access(pkg_name, 0)) > return 0; >-- >2.26.2 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.