* [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values
@ 2020-05-28 5:39 Haiyue Wang
2020-05-29 1:11 ` Ye Xiaolong
0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2020-05-28 5:39 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang, xiaolong.ye; +Cc: Haiyue Wang
The PCI DSN (device serial number) to format package file name should be
lowercase values.
Fixes: d1c91179e952 ("net/ice: check DSN package file firstly")
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ice/ice_dcf_parent.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
index bdfc7d430..d13e19d78 100644
--- a/drivers/net/ice/ice_dcf_parent.c
+++ b/drivers/net/ice/ice_dcf_parent.c
@@ -242,13 +242,13 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
- ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
+ ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg",
(unsigned long long)dsn);
if (!access(pkg_name, 0))
return 0;
snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
- ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
+ ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg",
(unsigned long long)dsn);
if (!access(pkg_name, 0))
return 0;
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values
2020-05-28 5:39 [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values Haiyue Wang
@ 2020-05-29 1:11 ` Ye Xiaolong
0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-05-29 1:11 UTC (permalink / raw)
To: Haiyue Wang; +Cc: dev, qiming.yang, qi.z.zhang
On 05/28, Haiyue Wang wrote:
>The PCI DSN (device serial number) to format package file name should be
>lowercase values.
>
>Fixes: d1c91179e952 ("net/ice: check DSN package file firstly")
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_dcf_parent.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
>index bdfc7d430..d13e19d78 100644
>--- a/drivers/net/ice/ice_dcf_parent.c
>+++ b/drivers/net/ice/ice_dcf_parent.c
>@@ -242,13 +242,13 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
> rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
>
> snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>- ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
>+ ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg",
> (unsigned long long)dsn);
> if (!access(pkg_name, 0))
> return 0;
>
> snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>- ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
>+ ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg",
> (unsigned long long)dsn);
> if (!access(pkg_name, 0))
> return 0;
>--
>2.26.2
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-29 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 5:39 [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values Haiyue Wang
2020-05-29 1:11 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).