From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 134CBA04F2; Sat, 30 May 2020 12:02:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D45BA1D605; Sat, 30 May 2020 12:02:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id BE3A81D547 for ; Sat, 30 May 2020 12:02:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04UA0iUP001143; Sat, 30 May 2020 03:02:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=H4xHJEzD/5lEM+92NKwLq53GfcLXodCLrqALjxtv1j8=; b=iNDgu4vdr4ICjrj6DcqF0XQAQG5fCJwZa0ENixWy6l9PYj1ozjtlzDSDCIw/1BDwb3Qc 9RO+CRedz3VD7Z5vQOLQhwqgYT0UQX6/kHycy7INlnBTzPXoFP/qsEPukEg5LSM+QwbZ Af5ZvQ/buhVyOoH6gvV3hGmhXJ/TBNrYBXIGNVeX8PRlIXz9iMxteURzBawlbrENtsCH atOsesWY1kqE8tRUPbqTP1MlJ3Apa3JzmYmIf/08VZ3v/G5HPUzFogSX2L2byLv/IEn1 PxXxiVDd40nWfbaNsdyga9wnrbbbqHMM1f2M8BTOAJIaBjmwnjDwjOK4zdrFJjbPQa/S qQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 31bmupg36x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 30 May 2020 03:02:47 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 30 May 2020 03:02:46 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 30 May 2020 03:02:46 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sat, 30 May 2020 03:02:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7rws8Y7Vq0LVIXYFiD0lBOAbetWKNG5k+jClOVvOxV+pYkLtvVY+POBKCNaXybYWWbAghmm5XoDvmHvC2EHfDAx83WCD2ZH2cZJrOY0qdcroaOJl+2Ja0bDPRjFZwVfOpay1KOzBRh/mLq9AxJ2y6bNkxEcfmsDtYZ/FovCsSXraVQ1PvBMSvgZ+K8C3/E0fd4DZqMYDStanrqoYGCnJoCWWSnq2/NLeBjh15Om3K5vH+KGq9hXWJsmg/LzdJfinWpugvrwKzYruYcmeMtShZbCMXTemunh2a2ps6HeBShPqEx6FHKMh/BHOgNj4EYxZ9i+krmPrKYa9el34ovWcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4xHJEzD/5lEM+92NKwLq53GfcLXodCLrqALjxtv1j8=; b=DnRN2Ik1mDcx8IlFCdnV6eNPgmSSxsibcuvlaBtVFmZS1OItOGOe0TrXm/PUoDdNNiESt5XLdeayvM36pcGNdwsmFFlgSRhDQo8ioISEtGxIQQJ0+XHhAz0v5SiicYDnGgEpJLfoNceMFjMjZtaplR8Eb28vIi8ea4l88ZOnIoNApX7CLEJnPQOjTQLoBvP9AW20ZnkXElJRT0aJ5nhqWT1DSJ0BKDHWnWq+9nBMNZzXtCU2rVdSNNsKfo/fLAgsjdftCyICwDANnhbMp2T4LEv63Nj7mrBuIzL68Tpb7bo3prkpEVRDa/H4uE1P8MX+fFsJE6TmVPKez+Aon0UIzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4xHJEzD/5lEM+92NKwLq53GfcLXodCLrqALjxtv1j8=; b=pXVJR2anKwyAdUKpXzvUOJg5J1ZIu5vTqSES2CzlvU6qIW7sHqeyqRvWWAkIfGU4oua0TlPySFHfacTEX98tj1zfN/OuJpjaHH7KQkTrmpRViLe3srBI57vXvHoS1Tk0o+WHuIRbsA/lK8AzeLnrlzpNmsEpWqqt64BCJi7Q1Qo= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; Received: from MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) by MN2PR18MB2941.namprd18.prod.outlook.com (2603:10b6:208:a2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Sat, 30 May 2020 10:02:44 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::a8b1:45c4:b84:9c02]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::a8b1:45c4:b84:9c02%7]) with mapi id 15.20.3021.031; Sat, 30 May 2020 10:02:44 +0000 Date: Sat, 30 May 2020 15:32:30 +0530 From: Harman Kalra To: "Burakov, Anatoly" CC: , David Hunt , , Message-ID: <20200530100228.GA24648@outlook.office365.com> References: <20200529131955.GA83122@outlook.office365.com> <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-ClientProxiedBy: PN1PR0101CA0033.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::19) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR0101CA0033.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.18 via Frontend Transport; Sat, 30 May 2020 10:02:42 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3b066fb-4d35-4672-d2de-08d8048098e1 X-MS-TrafficTypeDiagnostic: MN2PR18MB2941: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 041963B986 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l3DD6dedMyRdwBzBiKgn+0BQpWBqUScvMjvKFsHerA9hQPIkCl7YMBmFlxEWFDSQfNWi/NmicG059qDP/4K/ab8CzYswxqS0u1lyNI8zcPkDgfkj4M+/JTe+gNjYKES12WyemNor0xQ0j/88yyLnP9b/gGkKwZFZPVl8IKUiy+UOgX17CvT0CKT9GvSNAxYI7/6emMBZoknPWiFmw9kxS2gTlJQdC45RD9h91eIMflqqk+ZEp/Oj/Q5+uHJSWDQYi6Dg3wsh7tJrXAKotoEb+3iMsMsD49+scYftzYH5uctkqHjcAdS+VtMdgbsPVU4WLPmtjRiQAEgm9I6RZ6p5s3pVnFdqTIF5HLy/JFbc6ZQ5TkpXSebUkLHV4nHXXtLg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2848.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39850400004)(346002)(136003)(376002)(366004)(55016002)(6506007)(83380400001)(186003)(6666004)(6916009)(16526019)(55236004)(5660300002)(478600001)(26005)(53546011)(316002)(1076003)(52116002)(7696005)(9686003)(8936002)(86362001)(4326008)(956004)(33656002)(2906002)(8676002)(66946007)(66556008)(66476007)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: evzHe1rDccv44vbcnBGlRVQYqX+14YkEtCttPUKZhYR6wQLVAA5YhZqcOpd4SdhNc54/Z7rer3DW/B+Dy69Vd7azi3OwJbs8gPElDc4gafbh4O5dsxHozrjeuM5PRuR+kxMMhupoZ9leYHsU/vnGa52jOysLFbUEFHWZvgvTD2jsIJ5tyNS2rfwzum55P6LwqtyndZhzRyi4MEPxLzS37+8/uSfmOFRjAteuFoCJtmH+zymZxZoU7mVq9RqNDd1lyl//z6458uNQoagKrRkND/cJz+b9L4CvMNhz3CCQYfInkxXXtdcgAZdZ4inZatgYM9XzC7hToo6QQ9yzAgSaQmKbXZCjOU3Hnr9XTpd/isSJw83ZsFh6L0UszJdGhXBdA7nAGi78oHPrIO5XdRYj56LDlmMDXySynwM2QjO3sRgmvUhPpwFGZRA+oxSFMIBcFLmlxNIbCToxqV36LWm033RWjQ9QdDjj1XLEcOAefOA= X-MS-Exchange-CrossTenant-Network-Message-Id: d3b066fb-4d35-4672-d2de-08d8048098e1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2020 10:02:44.2575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R9aaijurLZq72SO1h3MBnOiojIZKE5L0St7aHqmboiuy1y6imrBTyD5OdyFzw/V6uxdCKtOsw5VjtjBBVMZXFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2941 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-05-30_03:2020-05-28, 2020-05-30 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: > External Email > > ---------------------------------------------------------------------- > On 29-May-20 2:19 PM, Harman Kalra wrote: > > > > if (ret < 0) > > > rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); > > > - if (app_mode != APP_MODE_TELEMETRY && init_power_library()) > > > + if (app_mode == APP_MODE_DEFAULT) > > > + app_mode = APP_MODE_LEGACY; > > > + > > > + /* only legacy and empty poll mode rely on power library */ > > > + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) && > > > + init_power_library()) > > > rte_exit(EXIT_FAILURE, "init_power_library failed\n"); > > Hi, > > > > Rather than just exiting from here can we have a else condition to > > automatically enter into the "interrupt only" mode. > > Please correct me if I am missing something. > > Hi, > > Thanks for your review. I don't think silently proceeding is a good idea. If > the user wants interrupt-only mode, they should request it. Silently falling > back to interrupt-only mode will create an illusion of successful > initialization and set the wrong expectation for how the application will > behave. > Hi, Thanks for the explanation which even I also believe is logically perfect. But since l3fwd-power is an old application and has many users around which are currently using this app in interrupt only mode without giving an extra argument. But suddenly they will start getting failure messages with the new patchset. My only intent with else condition was backward compatibility. Or may be we can have more descriptive failure message, something like "init_power_library failed, check manual for other modes". Thanks Harman > -- > Thanks, > Anatoly