From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D1E9A04FC; Tue, 2 Jun 2020 12:23:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A27251BF7A; Tue, 2 Jun 2020 12:23:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 176E91BF76 for ; Tue, 2 Jun 2020 12:23:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 052AFVjP002048; Tue, 2 Jun 2020 03:23:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=yi0/GGWVm+efQtMl056yUEEemR7eUTj3xMrR8D2GZck=; b=PSuwoPqvNbJFZENJ6Mg44knvGxYTXbUsyOzkLnhjonUfQ/ukqHZEjkrduS53gtbtTE9h dDJSi4FhtogYA8ll547PMxLWSVLxe7+Xp9JUrxw6Tu5NZZEBPKPPqleY9lZcgyiFN8Pi oZ3hBqfil10B+AxBdowTjdF4GGDrzf5vT53BVUxg+3om5Frh72QLqdUG+RmQvBlHzLb1 0FJYcE6QA4NdrEX6eDL3AAmGltAZ7jtzu0lxPctWzSDrQ4bA9DDwyHQzzDX/k1RWtOdg 4DK4nctdpCgT8YAEZfzKdSvajnKgUnNddKL5X8OWTNltRrthB7zknF2hezzI68zkIkAg hA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 31bmuptjch-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Jun 2020 03:23:25 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Jun 2020 03:23:25 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Jun 2020 03:23:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 2 Jun 2020 03:23:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EufOD8jnuehSTDGYsGNJK5w/YCUp00LDR3boA6o0btyW3+JmakcFEMa9++8P2Ey3wFFqjbSXzo8TKC0nWPmLC2Q49tkvKEiVw6pGpk93QB0X8fbRRuaCe4qYe4dNk7S2oMXW+uTiZvLkrvRCKys1MMvcAnhnthsybALTs3Q/rC9ENaoONVTe1pr4XbxOWxYBj4LDHNZVe0e1nd9MwcoXQmhYl98FbNpPw2ygL4TlArrc2BMIzU+zlf7Lz7b9KBewzayEeFDxjFjWyhBsTeoqSBRZTvyk0GLaLvPTDUxQ1eAAX+xMvUstel5WOxBcWvWgRiYrja/+rm2WlctniyIQZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yi0/GGWVm+efQtMl056yUEEemR7eUTj3xMrR8D2GZck=; b=CV18MJc9PvZtYfrV0Gy6q7EpJIe6a66+GkACU0pcDZQuZiQ5orY9vewrpM3itLl/vgSq4LkDiGFsrPOCiogkrr9dvMdkE6oiIkI5xhKH49tLXV5oRCYSrnrq5XjZ+vJck+fLRpl4ryykKajdhCCjXIUV/OeHsbE5heykzdHAAsTfgkalvXCq70Rhf2fSpSfLC219ygxgjQvDaiPbP06JTAtWp3sr87XUYOwQE6NMFNWWaCeMSAeU5eEKFza24/D0irrF2DMpJHW8EgCxo+llpqJmkBkUWiy1HLsK7V7OxJp7Bq0UmtIki846Mlj1LAqKG5WcVOkEDaFkMLa6IH+gXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yi0/GGWVm+efQtMl056yUEEemR7eUTj3xMrR8D2GZck=; b=Fb4Fhle9fNYD+4cpKj+6kSaGWG62Y0pXorHhl4Y8BluQDNZuvdXASpYdxfAEEmG+uyV8bXJNvCQ6/AjqDSCopne5i7gsSLrrPpN7IdfoGJrSIZ8ImkVthOWnYN0hfU664Y0DEIkqR8K000pLROesDKl0PWmBLtFc8Hubxdw7YoI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; Received: from MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) by MN2PR18MB2832.namprd18.prod.outlook.com (2603:10b6:208:a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.21; Tue, 2 Jun 2020 10:23:23 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::f4fb:5e32:18dc:fb93]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::f4fb:5e32:18dc:fb93%7]) with mapi id 15.20.3045.024; Tue, 2 Jun 2020 10:23:22 +0000 Date: Tue, 2 Jun 2020 15:53:07 +0530 From: Harman Kalra To: "Burakov, Anatoly" CC: , David Hunt , , Message-ID: <20200602102259.GA54715@outlook.office365.com> References: <20200529131955.GA83122@outlook.office365.com> <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> <20200530100228.GA24648@outlook.office365.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-ClientProxiedBy: PN1PR01CA0117.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::33) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0117.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Tue, 2 Jun 2020 10:23:20 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 806086a4-ccd9-48e4-b762-08d806defa47 X-MS-TrafficTypeDiagnostic: MN2PR18MB2832: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0422860ED4 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0SNy/Fs0rUMCgIYguzJh7UwoE8feLiGhi7ih13KSA7CdJ7WEv084mhtEvWAdpHlra+MmcrDaubNloOWeZ43DUKBf/XUk29Gh2g4AUmkhxZ0W1ZqbS1cgW4LgmyXBTcTau+bIRwrNLzbZQuy77H0IVAaPDsjAp28GxxKJfEQVJXuw6yU2FpSR9vT5UEMkL05OXzkQzmVOTin2ETq2JF4PCRBmocxZA94aPPtbTa37iTvrSapAKU8bHm0yffj0JnQAcSTjQtY7JM8AEhuauK4UnO8exQJRIZa2sZIquwQc3eJHo95YMMtX7FCdH4FpceVFeL/hRp049+2A8zN4bCOXA+vihOY2PZdA0XaO3Kzz/hI7YnXNSi4YlTTnlyYhp2EW X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2848.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(316002)(6666004)(86362001)(478600001)(8676002)(33656002)(4326008)(6916009)(55236004)(83380400001)(2906002)(26005)(66476007)(5660300002)(16526019)(8936002)(55016002)(7696005)(956004)(66556008)(66946007)(53546011)(52116002)(9686003)(186003)(1076003)(6506007)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 8M+9dL/AVOBgPFYOoB0VySP+O2vhbeHE1pYcMbrj5Eysfwe/u+Ed6t2vqg14wzhOjNMXnAFUj+6OEc+JuHyO5QXKM2nfdRtv7mAh+cduQTOX5blxHYwEHnnwAqkQurumgO/bQ5QKms8uL4Dt94yG/UCmHn5ANSwCCacjiXS28fdPrnhJRYU82m0jjjsUPdQMtQNC5fhK+nP9chln3k4Bo1jXXrOf0im3pdbP2jdCyOBKc2lRw2wVEgUwdevlQP0D3L/SfVTpPaNXU72ImIQxICu1qVWWG7MVAYKQF+KU6BV3aLFv7L1kMU+t289/81wnICdfxKA4FhYYfAFYK6BQEDrv6nAbU7rPpYIbNA+jJNejgfImwfJGIa8FYXNs1i0W8DSWixxxYJNaENfwdDgAgVOBi6RfUvBe6Z9JZu7dfQFlmpOHGDw5mQ7D7RlQhZMzocZA7u6qxE+Zca1vSUO0H3q8VYNKrDekv98CnOgcBHg= X-MS-Exchange-CrossTenant-Network-Message-Id: 806086a4-ccd9-48e4-b762-08d806defa47 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2020 10:23:22.7024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q2J60AOOFgLlutltfGokiBKDKPCQS62JfeC1/W2d7xeoHaVp/Go+O6WeXkKr3GJilKCJyemKxU/+8dNLoR2h2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2832 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-02_12:2020-06-02, 2020-06-02 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: > On 30-May-20 11:02 AM, Harman Kalra wrote: > > On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: > > > External Email > > > > > > ---------------------------------------------------------------------- > > > On 29-May-20 2:19 PM, Harman Kalra wrote: > > > > > > > > if (ret < 0) > > > > > rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); > > > > > - if (app_mode != APP_MODE_TELEMETRY && init_power_library()) > > > > > + if (app_mode == APP_MODE_DEFAULT) > > > > > + app_mode = APP_MODE_LEGACY; > > > > > + > > > > > + /* only legacy and empty poll mode rely on power library */ > > > > > + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) && > > > > > + init_power_library()) > > > > > rte_exit(EXIT_FAILURE, "init_power_library failed\n"); > > > > Hi, > > > > > > > > Rather than just exiting from here can we have a else condition to > > > > automatically enter into the "interrupt only" mode. > > > > Please correct me if I am missing something. > > > > > > Hi, > > > > > > Thanks for your review. I don't think silently proceeding is a good idea. If > > > the user wants interrupt-only mode, they should request it. Silently falling > > > back to interrupt-only mode will create an illusion of successful > > > initialization and set the wrong expectation for how the application will > > > behave. > > > > > > > Hi, > > > > Thanks for the explanation which even I also believe is logically perfect. > > > > But since l3fwd-power is an old application and has many users around > > which are currently using this app in interrupt only mode without giving > > an extra argument. But suddenly they will start getting failure messages with > > the new patchset. > > > > My only intent with else condition was backward compatibility. > > Or may be we can have more descriptive failure message, something like > > "init_power_library failed, check manual for other modes". > > > > Thanks > > Harman > > > > > > I think we can compormise on an informative log message suggesting to use > interrupt mode. I'm not keen on reverting to previous buggy behavior :) > Hi I am not insisting to revert to previous behavior, I am just trying to highlight some probable issues that many users might face as its an old application. Since many arm based soc might not be supporting frequency scaling, can we add the following check as soon as the application starts, probe the platform if it supports frequency scaling, if not automatically set the mode to interrupt mode, something like: if (access("/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor", F_OK)) app_mode = APP_MODE_INTERRUPT; Thanks Harman > > > -- > > > Thanks, > > > Anatoly > > > -- > Thanks, > Anatoly