From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFF7BA04EF; Wed, 3 Jun 2020 04:00:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EB841BF60; Wed, 3 Jun 2020 04:00:10 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 4FCD91BF4E for ; Wed, 3 Jun 2020 04:00:09 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id u5so631328pgn.5 for ; Tue, 02 Jun 2020 19:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PNMiL9DUDCxFKxzHyzfExr3QoqBIhjeIq6fl+sXCI30=; b=zuAhMYpUdbQysfGRt6L7bbnzE2YZFTbyut3Ge2SMC/vtoZ1hVz9DRY9yeZ5NlNgYoN R5czG2KEpe6KlEqjCSAosz5MdChlsHnhPMvjMAZ41SLDqkVl8qC6OdoXSBirTNZbpM2c gQQrB5GKYTWE+xjdFIUEmW0/4fLUheJ7sC7Vwg3qjrKI9xZ0lUdokrri7amtoY6YEUN2 MvtnZ+oAsOWBf2orowIm94Pv9nhqJ539728GNbC3iWuf44H6drbU9DncZ0xHFVkrh6b2 hZTguRQrDN0aYaqGqHOTBEloOOE4D8/VAApXh66UA5M41Z+4tNsviSnzIQsT/M9aiUNt D0vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PNMiL9DUDCxFKxzHyzfExr3QoqBIhjeIq6fl+sXCI30=; b=h56gzv629XXP0r4RQ9MeHdzhYDpC+oOpgxhKIzXHDiNBMDtiZK2nnTGl+wkWIj9Ofa oeh6spNWypze6k6mPP5HsYwIQiXsBH/JP+y9RcsBm+QL+Q0WQ6RXPglGbkOyrZcPVStF M/s7n8cGZmVEmJtHB2mlSZD7tpesDa6KXbp9a2utFEaWzgHProEum9Ai3gTBWOFd+Sax ROYVv2X3Xc7+gppS4AlpNT5m35vBx3JZZbk5q5gpMSPOUATPlN6wYSmx+uvBNksH1E/p fyM0nr/i5aXqzve/Hqnkjr8bVpL3EL/8lJ2IDPy6RoINoXQ1Sv1rBQr6jixEZdOXy0dG 5t7Q== X-Gm-Message-State: AOAM5307DQ2k5LTKjJ0ITXxR01qkHExtwv5aFFYjPJdghsBK2Tn4nfB3 P3X6HBrzI/n/dPN8yQc5rbNTnw== X-Google-Smtp-Source: ABdhPJwhjJSXtWgEDuGCqm9enA4qhOgp8PwSPiErGgCzB7W7Aho52oFdpX3SlhU/CInGacuVYI4f4A== X-Received: by 2002:a17:90b:4c8b:: with SMTP id my11mr2520881pjb.153.1591149608384; Tue, 02 Jun 2020 19:00:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f6sm350670pfe.174.2020.06.02.19.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 19:00:08 -0700 (PDT) Date: Tue, 2 Jun 2020 18:59:57 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Jerin Jacob , John McNamara , Marko Kovacevic , Anatoly Burakov Message-ID: <20200602185957.5383e9f3@hermes.lan> In-Reply-To: <20200602230329.17838-2-dmitry.kozliuk@gmail.com> References: <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200602230329.17838-1-dmitry.kozliuk@gmail.com> <20200602230329.17838-2-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 01/11] eal: replace rte_page_sizes with a set of constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 3 Jun 2020 02:03:19 +0300 Dmitry Kozlyuk wrote: > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > Enum rte_page_sizes has members valued above this limit, which get > wrapped to zero, resulting in compilation error (duplicate values in > enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. > > Remove rte_page_sizes and replace its values with #define's. > This enumeration is not used in public API, so there's no ABI breakage. > Announce API changes for 20.08 in documentation. > > Suggested-by: Jerin Jacob > Signed-off-by: Dmitry Kozlyuk In this case #define makes more sense. Acked-by: Stephen Hemminger