From: Bruce Richardson <bruce.richardson@intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Luca Boccassi <bluca@debian.org>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] autotest: fix for pure python3 environments
Date: Thu, 4 Jun 2020 17:22:36 +0100 [thread overview]
Message-ID: <20200604162236.GB1543@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAATJJ0L3vY1KNo_RXvxSG+_YARBw_4Umk4D0Q35ysLxvhp6gOw@mail.gmail.com>
On Thu, Jun 04, 2020 at 04:43:50PM +0200, Christian Ehrhardt wrote:
> On Thu, May 7, 2020 at 1:25 PM Bruce Richardson
> <[1]bruce.richardson@intel.com> wrote:
>
> On Thu, May 07, 2020 at 10:36:35AM +0100, Luca Boccassi wrote:
> > On Thu, 2020-05-07 at 09:26 +0200, Christian Ehrhardt wrote:
> > > Without this fix in a pure python3 environment this will run
> into
> > > issues like:
> > > ModuleNotFoundError: No module named 'StringIO'
> > > or later string encoding issues on check_output.
> > >
> > > Signed-off-by: Christian Ehrhardt
> <[2]christian.ehrhardt@canonical.com>
> > > ---
> > > app/test/autotest_runner.py | 16 +++++++---------
> > > 1 file changed, 7 insertions(+), 9 deletions(-)
> >
> > Acked-by: Luca Boccassi <[3]bluca@debian.org>
> >
> > Note that this makes the file python3-only (as far as I can see) -
> I
> > think it's fine at this point, given python2 is EOL?
> >
> I think for 20.11 we should aim to have all python in DPDK python3
> only.
>
> IMHO Robin's feeback wasn't forcing a mandatory v2 (I wa not planning
> on one).
> Nothing else happened on this, since we failed to hit 20.05 I wanted to
> ping again on this.
>
Just to note that similar changes/fixes are included in set:
http://patches.dpdk.org/project/dpdk/list/?series=10204
next prev parent reply other threads:[~2020-06-04 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 7:26 Christian Ehrhardt
2020-05-07 9:36 ` Luca Boccassi
2020-05-07 11:25 ` Bruce Richardson
2020-06-04 14:43 ` Christian Ehrhardt
2020-06-04 16:22 ` Bruce Richardson [this message]
2020-05-07 9:43 ` Robin Jarry
2020-06-04 16:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604162236.GB1543@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).