From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8F6CCA00C4;
	Fri,  5 Jun 2020 10:30:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C6DB81D5DA;
	Fri,  5 Jun 2020 10:30:42 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 8A23A1D5D5
 for <dev@dpdk.org>; Fri,  5 Jun 2020 10:30:41 +0200 (CEST)
IronPort-SDR: Vflfc/fAb0+4BTtUtClYGxf+w/bjXTbW2HNG7Nm7WYKan+ItQDF08WXChehiKnnY1HAPRU8WkC
 g1WebdB5bWCQ==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 05 Jun 2020 01:30:40 -0700
IronPort-SDR: Vdlt1aQMzpz8YhfFu6GZgVgdjqGK8WBaNU7xRKxpJXTdTkyITxdGhzxUDStKeyUuN7I/tovBNv
 zkBCvvdeo72A==
X-IronPort-AV: E=Sophos;i="5.73,475,1583222400"; d="scan'208";a="417201440"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.61])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 05 Jun 2020 01:30:38 -0700
Date: Fri, 5 Jun 2020 09:30:35 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Andrey Vesnovaty <andrey.vesnovaty@gmail.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, Ori Kam <orika@mellanox.com>
Message-ID: <20200605083035.GA1552@bricha3-MOBL.ger.corp.intel.com>
References: <20200520091801.30163-1-andrey.vesnovaty@gmail.com>
 <318236911.yWikKUQR1j@thomas>
 <CAOwx9Suoxw7BvPEuJoe0LvgbFHsq-s+ZqPqC45U8K04Ed-9egQ@mail.gmail.com>
 <2468319.zLU6FhoSUI@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2468319.zLU6FhoSUI@thomas>
Subject: Re: [dpdk-dev] [RFC] add flow action context API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote:
> 04/06/2020 13:12, Andrey Vesnovaty:
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 20/05/2020 11:18, Andrey Vesnovaty:
> > > We had "create", "destroy", "query", but no "modify" capability.
> > > The new API is adding 2 things in my opinion:
> > >         - shared action object
> > >         - "modify" capability (is "update" a better wording?)
> > 
> > Naming is one of the most challenging parts of this RFC.
> > Some similarity I have found in existing code is
> > rte_mtr_policer_actions_update()
> > Is there any existing code having update/modify semantics?
> 
> Except one callback in librte_fib, no DPDK API has "modify" in its name.
> You can find the word "update" in the API of multiple DPDK libs.
> I would like having the opinion of a native english speaker here.
> 
>From a language viewpoint either is fine for conveying what the API does.
In this case "update" would seem to be better for consistency reasons.