From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E1B3A04A3; Fri, 5 Jun 2020 20:35:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8250B1D5AA; Fri, 5 Jun 2020 20:35:25 +0200 (CEST) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 4EF111D58A for ; Fri, 5 Jun 2020 20:35:23 +0200 (CEST) Received: by mail-pj1-f67.google.com with SMTP id k2so3034508pjs.2 for ; Fri, 05 Jun 2020 11:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ROhiJg26sTpkfF1Z5hVqUw44MQ5Rb2dIJIk+4SGftB0=; b=NOmt3NPx6SoYpG3is5tH9IRnBYsYZTIqC54qEInNVaWNZp8JQY7unx79XI6EPHF3v2 GfOQsGlLFXYe0+H4UlJhpQY0fTYm1j8AjqRkTQXJqV6HViWmQhOvGE6EkJ4sf4vlt2sB Ojvw3fUyAlJIgMvT0z6qdrdskd7BAloCHk6edejqsNNUOkT+4P+mPethptC6tljDnWs2 v8jxMDenKHlXf97VlSg/tuIeA/htipzyOf52Laq/hUhp2orQqLAQeoWqmNGaXLeRMboP ngTIKsftf6uBxnmjqdXiq+iIv5Xa/2km8zYsjaNS6iZjzYsvM6N8bPJTdOKkyVl7VbHD Q8uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ROhiJg26sTpkfF1Z5hVqUw44MQ5Rb2dIJIk+4SGftB0=; b=BNtOidhfC1sXkOwrunSH0XHxMc2AFm6f9/PZPvpGAx/0lLbPxhRKrBFo3RQKW3L+JA 7rCpkgKFvszQbyz0D6dvcebe3Q3a2yk6O8XCs5kW+65n1YJaIskBTJHEazE86uYnLFF8 NkhouQewNndNZIxK4P1ytEfLjjl2g24CxQRDvvsfAJTui5BVSt3848Xf5AkdCGXKO8VF zuO1n6jlAEXInQ86y7t8dbzJ5obeaDfoSoe6M+MMrSQRl1vXRZqhQt4ac1/aqorB+fox LzDGhCZfM19Vu4QQV6V68BI2epGJLj7cKkIQpc/jr2kA5WiHfr2qk++r4lBnqksljMKe ca7Q== X-Gm-Message-State: AOAM531v1m71fZq1lIaB27AivJZef0B4Gl0CA9PLjND1SDPorpORSVhi 1jVB5zYo4IZW76qMIJYPN7T0Mg== X-Google-Smtp-Source: ABdhPJwy63/+RRiVUBJnIMDyelPyhs7OWYLjy/i8rjcf54HWvPAEYDslv1pqR08jYhbyfEEVn1noLg== X-Received: by 2002:a17:90a:dc16:: with SMTP id i22mr4597184pjv.84.1591382122327; Fri, 05 Jun 2020 11:35:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id ca6sm8453286pjb.46.2020.06.05.11.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 11:35:22 -0700 (PDT) Date: Fri, 5 Jun 2020 11:35:08 -0700 From: Stephen Hemminger To: Yipeng Wang , Sameh Gobriel , Bruce Richardson Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, pablo.de.lara.guarch@intel.com Message-ID: <20200605113508.746ba6b2@hermes.lan> In-Reply-To: <20200604171731.6738-1-stephen@networkplumber.org> References: <20200604171731.6738-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 4 Jun 2020 10:17:31 -0700 Stephen Hemminger wrote: > The code in rte_cuckoo_hash multi-writer support is broken if write > operations are called from a non-EAL thread. > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > thread and that leads to using wrong local cache. > > Add error checks and document the restriction. > > Fixes: 9d033dac7d7c ("hash: support no free on delete") > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > Signed-off-by: Stephen Hemminger > Cc: honnappa.nagarahalli@arm.com > Cc: pablo.de.lara.guarch@intel.com This restriction also needs to be added to the known issues section of EAL