From: Sarosh Arif <sarosh.arif@emumba.com>
To: dev@dpdk.org, reshma.pattan@intel.com
Cc: Sarosh Arif <sarosh.arif@emumba.com>, sergio.gonzalez.monroy@intel.com
Subject: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
Date: Fri, 5 Jun 2020 16:48:28 +0500 [thread overview]
Message-ID: <20200605114828.20372-1-sarosh.arif@emumba.com> (raw)
rte_exit should be called when the application exits due to
invalid EAL or application arguments.
Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
Cc: sergio.gonzalez.monroy@intel.com
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
examples/packet_ordering/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index b397b318e..edaf810d9 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -675,7 +675,7 @@ main(int argc, char **argv)
/* Initialize EAL */
ret = rte_eal_init(argc, argv);
if (ret < 0)
- return -1;
+ rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
argc -= ret;
argv += ret;
@@ -683,7 +683,7 @@ main(int argc, char **argv)
/* Parse the application specific arguments */
ret = parse_args(argc, argv);
if (ret < 0)
- return -1;
+ rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n");
/* Check if we have enought cores */
if (rte_lcore_count() < 3)
--
2.17.1
next reply other threads:[~2020-06-05 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 11:48 Sarosh Arif [this message]
2020-06-23 9:19 ` Sarosh Arif
2020-06-23 9:22 ` Pattan, Reshma
2020-07-13 13:28 ` Sarosh Arif
2020-07-30 21:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605114828.20372-1-sarosh.arif@emumba.com \
--to=sarosh.arif@emumba.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).