From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67C00A04F2; Mon, 8 Jun 2020 21:17:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 084382C58; Mon, 8 Jun 2020 21:17:34 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 14F3F2C57 for ; Mon, 8 Jun 2020 21:17:32 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id m1so9216320pgk.1 for ; Mon, 08 Jun 2020 12:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FQBev6ymVAxQ3f+6D8DwXqU/StQT7F6PyzRzJIKL0iw=; b=lVWobq3Tm17LVzHY/9arUvylfUiZh0bglSUWdvaOCiQsjBA0HX/02rz5U+wNbfv+N+ zTCvtaNxa+fzOVTscgdVZAz7ImMXH5b4ySXTyhJgYDdN1IJ/SGWbmOwZKfoLVV4EnIu4 cne5Sn31rm+mXrJCMPHSXQPP+hlaXraHrQdMhMGAVGZwACtWGDdidjnhe19aVtY8ERR/ Ae/byRk3+Fe2pPRmX+wa34o7PgM7MpbDIdxeMoj2lQx5h64sEAAcMosXW6D5o09fY018 /Q6ULpb/lSQpCbRmuMMGMX6xZDDRY87+XsCrA/kBqxaGoYtGA15n5NkNh6d0wugc0kVS SIeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FQBev6ymVAxQ3f+6D8DwXqU/StQT7F6PyzRzJIKL0iw=; b=UDOC0ccobGX47aIow9gDMyzdplyK8hwpKqdFcPygxWHEhO1wnHjTKFXXs/m/NPd3TY 7PeZDCHJR9JQ5GrfuWccHIxVHdiBDXwvZj3qSgITdIaL07i2FkuDuCkPYJ+j6v1SfKpk IDQbJYdZysb5gjfaxiNfH57jz2n+QCi7pXNjryLfFL7CfnBwHltxEnBazHtpoNfP2EHs 1zm3o61goBgOds6QWDMPYuixqiZnCZscGbFryAC7iokWkGByRo8lWK8fZxnx6tlDyJGW DxTHjuswB1+yGk/OUar3e5MaliOd00hj7BhmZxO2Xr2stSooP+ZtzJEcXwkpUj2P4oNn wswg== X-Gm-Message-State: AOAM533mB02JBXGu1OFCu3iK9sEJ1heDV+iZPFLs2ruKv/R48DrxB7gX 4P0VsdZcCvF4v09HiS0NMZ+w2/N8UDE= X-Google-Smtp-Source: ABdhPJyl0KVvt0EQ6Ws+Q2vwuAj5CnxmRnh+nhfqez61YJxXARWe8nPG+yH+F56fvPekunG6s3/9Ww== X-Received: by 2002:a62:7a4a:: with SMTP id v71mr23229834pfc.35.1591643852028; Mon, 08 Jun 2020 12:17:32 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x197sm7836150pfc.13.2020.06.08.12.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 12:17:31 -0700 (PDT) Date: Mon, 8 Jun 2020 12:17:23 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20200608121723.7a042105@hermes.lan> In-Reply-To: <20200608164640.189755-1-bruce.richardson@intel.com> References: <20200608164640.189755-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson wrote: > Rather than continuing to recommend an 80-char line limit, let's take a hint > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Signed-off-by: Bruce Richardson > --- > devtools/checkpatches.sh | 2 +- > doc/guides/contributing/coding_style.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 158087f1c..4970ed830 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -15,7 +15,7 @@ VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path > # to a dictionary.txt file if dictionary.txt is not in the default location. > codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} > -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} > > # override default Linux options > options="--no-tree" > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > index 4efde93f6..1db3a7bbe 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -21,7 +21,7 @@ The rules and guidelines given in this document cannot cover every situation, so > * In the case of creating new files, the style should be consistent within each file in a given directory or module. > * The primary reason for coding standards is to increase code readability and comprehensibility, therefore always use whatever option will make the code easiest to read. > > -Line length is recommended to be not more than 80 characters, including comments. > +Line length is recommended to be not more than 100 characters, including comments. > [Tab stop size should be assumed to be 8-characters wide]. > > .. note:: I would even support going to 120 characters. Acked-by: Stephen Hemminger