From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24E3AA04FA; Tue, 9 Jun 2020 09:24:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F14D276C; Tue, 9 Jun 2020 09:23:59 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 30C282629; Tue, 9 Jun 2020 09:23:56 +0200 (CEST) IronPort-SDR: C2lrkUaKx/KqKiC6H0vBNUQJzEavwqLJheRBdyjQFHLYUDaiFMk2jdwmttov/Gryg7cC9VrN+Y 1DK5pgH2f03Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 00:23:55 -0700 IronPort-SDR: ekj3phnBF/Qa8W8a8C9ajI8K1Xo/YyhldQNWW9FzceDOwnpxbIwOmljMu2CttiOMjZdTR3kktZ MplIFk8JXaew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,490,1583222400"; d="scan'208";a="314128366" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jun 2020 00:23:54 -0700 Date: Tue, 9 Jun 2020 15:15:33 +0800 From: Ye Xiaolong To: Olivier Matz Cc: Konstantin Ananyev , Thomas Monjalon , dev@dpdk.org, haiyue.wang@intel.com, stable@dpdk.org Message-ID: <20200609071533.GB7842@intel.com> References: <20200609052955.59196-1-xiaolong.ye@intel.com> <20200609071729.GP12564@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609071729.GP12564@platinum> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused next member X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/09, Olivier Matz wrote: >Hi Xialong, > >On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote: >> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and >> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's >> next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te, >> next). >> >> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") >> Cc: stable@dpdk.org >> >> Signed-off-by: Xiaolong Ye > >Good catch, I forgot to remove this field which was used in former >implementations. Thanks! > >I suggest to update the title to highlight it's about dynamic mbuf: > mbuf: remove unused next member in dyn flag/field > >Apart from this: >Acked-by: Olivier Matz Thanks for the ack, I'll submit V2 with suggested subject. Thanks, Xiaolong > >> --- >> >> I found this issue when reading the mbuf dynfiled/dynflag feature code, >> mbuf_autotest is passed with this change, though I may miss something or >> this filed has some special design purpose, please correct me if I am >> wrong. >> >> lib/librte_mbuf/rte_mbuf_dyn.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/lib/librte_mbuf/rte_mbuf_dyn.c b/lib/librte_mbuf/rte_mbuf_dyn.c >> index d6931f847..953e3ec31 100644 >> --- a/lib/librte_mbuf/rte_mbuf_dyn.c >> +++ b/lib/librte_mbuf/rte_mbuf_dyn.c >> @@ -19,7 +19,6 @@ >> #define RTE_MBUF_DYN_MZNAME "rte_mbuf_dyn" >> >> struct mbuf_dynfield_elt { >> - TAILQ_ENTRY(mbuf_dynfield_elt) next; >> struct rte_mbuf_dynfield params; >> size_t offset; >> }; >> @@ -31,7 +30,6 @@ static struct rte_tailq_elem mbuf_dynfield_tailq = { >> EAL_REGISTER_TAILQ(mbuf_dynfield_tailq); >> >> struct mbuf_dynflag_elt { >> - TAILQ_ENTRY(mbuf_dynflag_elt) next; >> struct rte_mbuf_dynflag params; >> unsigned int bitnum; >> }; >> -- >> 2.17.1 >>