From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B33CA0517; Tue, 9 Jun 2020 15:57:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE3252A62; Tue, 9 Jun 2020 15:57:24 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9748C1252 for ; Tue, 9 Jun 2020 15:57:22 +0200 (CEST) IronPort-SDR: 5V6uYhScyAnasLP1QxRbUS5f0ooevFNP8KIawkZEMQD3y/KUFEkqe1d8xMmclFpAIK8R0ySRb6 WzfUtwbXRqfA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 06:57:21 -0700 IronPort-SDR: nfMgcGjxwgMgRXG2rwMWuk7r5NMYowXWkNipjmQ4H7D4g+4oUMquHFtBL4bNePbBv4PREN+AZU 0G62LFA/GSHQ== X-IronPort-AV: E=Sophos;i="5.73,492,1583222400"; d="scan'208";a="306196783" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.129]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Jun 2020 06:57:20 -0700 Date: Tue, 9 Jun 2020 14:57:17 +0100 From: Bruce Richardson To: Andrew Rybchenko Cc: "Ananyev, Konstantin" , Stephen Hemminger , "dev@dpdk.org" Message-ID: <20200609135717.GA1583@bricha3-MOBL.ger.corp.intel.com> References: <20200608164640.189755-1-bruce.richardson@intel.com> <20200608121723.7a042105@hermes.lan> <20200609092949.GA1565@bricha3-MOBL.ger.corp.intel.com> <5710188e-4bba-c909-34cb-1bb67cbc3af0@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5710188e-4bba-c909-34cb-1bb67cbc3af0@solarflare.com> Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: > On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: > > > >> > >> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: > >>> On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson > >>> wrote: > >>> > >>>> Rather than continuing to recommend an 80-char line limit, let's > >>>> take a hint from the Linux kernel[1] and aim for an 100-char > >>>> recommended limit instead. > >>>> > >>>> [1] > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > >>>> > >>>> Signed-off-by: Bruce Richardson --- > >>>> devtools/checkpatches.sh | 2 +- > >>>> doc/guides/contributing/coding_style.rst | 2 +- 2 files changed, 2 > >>>> insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > >>>> index 158087f1c..4970ed830 100755 --- a/devtools/checkpatches.sh +++ > >>>> b/devtools/checkpatches.sh @@ -15,7 +15,7 @@ > >>>> VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > >>>> # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL > >>>> to a valid path # to a dictionary.txt file if dictionary.txt is not > >>>> in the default location. > >>>> codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} > >>>> -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > >>>> +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} > >>>> > >>>> # override default Linux options options="--no-tree" diff --git > >>>> a/doc/guides/contributing/coding_style.rst > >>>> b/doc/guides/contributing/coding_style.rst index > >>>> 4efde93f6..1db3a7bbe 100644 --- > >>>> a/doc/guides/contributing/coding_style.rst +++ > >>>> b/doc/guides/contributing/coding_style.rst @@ -21,7 +21,7 @@ The > >>>> rules and guidelines given in this document cannot cover every > >>>> situation, so * In the case of creating new files, the style should > >>>> be consistent within each file in a given directory or module. * > >>>> The primary reason for coding standards is to increase code > >>>> readability and comprehensibility, therefore always use whatever > >>>> option > >> will make the code easiest to read. > >>>> > >>>> -Line length is recommended to be not more than 80 characters, > >>>> including comments. +Line length is recommended to be not more than > >>>> 100 characters, including comments. [Tab stop size should be > >>>> assumed to be 8-characters wide]. > >>>> > >>>> .. note:: > >>> > >>> I would even support going to 120 characters. > >>> > >>> Acked-by: Stephen Hemminger > >> > >> I think 100 is enough. > >> > >> In my case, I have a 1080p 24" monitor, and with two terminals > >> side-by-side 100 characters just fits inside each vim window. Going to > >> 120 would be fine for single terminal at a time, but I would find > >> awkward for e.g. side-by-side diff comparison in meld etc. > > > > My preference would be to keep things as it is - 80 chars per line. > > Having multiple different formatting styles in one source file looks > > really awkward and make it hard to follow. > > +1 > I wouldn't personally consider increasing the max line length as a style change, but even if you consider it such I'd worry about rejecting style changes on the basis that it may be different to what is there before. That logic means that we can never, ever change any element of DPDK coding style. I can see the issue with changes that require us to rework the style of code in order to comply with the new style, but changing the max length from 80 to 100 does not make 80-char lines incorrect and needing changes. Regards, /Bruce