From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38C1EA00C5; Thu, 11 Jun 2020 13:43:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D23582C23; Thu, 11 Jun 2020 13:43:19 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 202DA2BF7 for ; Thu, 11 Jun 2020 13:43:18 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id l10so5795045wrr.10 for ; Thu, 11 Jun 2020 04:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wtqoRKg/qaqA7MnfaNg24lIniPHIWCWZlPz5LQy7xpw=; b=PyZEYeh/Nha1XmSTZ6GRSzJwBIkcu1XqLAd/WuqT7FPlChc0xHCI7BhKqKB2CZfcHa D8GNdzrUN3CmOTcA/6w1E47+ABQWQYr06ZC5BmuW82MHXimTLCfvL58a4Nxy1K4yN2eV r4JxBzWDDHccVdKXisiaFgbIBODvCTwaafuuWUxDQVSOCJDsTccnZ06GdfMWAOiJtNOK yYNIn8Rtmv8WsxInKWiCX89dThKoEhbblprZjsmlOOHa/+icj9AmzMxBPS7LaM6f0NoG mo70Sj8jGFZpCG1m4wOUYpoFqHeHiK+7irXLUWhpsA+GefVC74l/vhqtEg9rZgh0huYl cLVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wtqoRKg/qaqA7MnfaNg24lIniPHIWCWZlPz5LQy7xpw=; b=N0FM35w1gZJ/qWQuXkGC7MiNpp9gU168NfjmSt3ANyAo4oKlaz9T0LvFhXI3hclEdL VsRcuyKT/VkkP0ULJkEM7xNE3bFO2/3PHBMex3W7HdGtKwkydVOiDfbXhuwfr3oPYTTW v7uZsPSCijoPOdci2ybCPk+pzd2clWJlQIdS3Es39JIKPJksYs+53JDvmDQ8JgVm/xRE 0cJD80rD5/MMOPjdibWod7rdHhhKAs1fBP5adz8x6HbsE/LNNMb/+oUTKy5FywCeysWt nT3cqPsDCshJbhF7efOIrc8fltrxhyl4mlsMYmS7U8P7kVUUihJDMtTYIvgrj54iJT27 9WkA== X-Gm-Message-State: AOAM531/JkXHzRf3bCt2y8PVdtBWLxnxo/+Yawa/bAOT5BfZVHAIbv+X HX1zK49DA4veblo+0MqlAD5cjw== X-Google-Smtp-Source: ABdhPJxWBDxaTxVeoEXILo8tAbIJI40EdysAn9+SuXCJOfE5bfNJGouBiXd9czF5Hrl0EDFeZ7RDDA== X-Received: by 2002:a5d:5449:: with SMTP id w9mr9312322wrv.106.1591875797777; Thu, 11 Jun 2020 04:43:17 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id n23sm3599916wmc.21.2020.06.11.04.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 04:43:17 -0700 (PDT) Date: Thu, 11 Jun 2020 13:43:16 +0200 From: Olivier Matz To: Ranjit Menon Cc: Thomas Monjalon , Dmitry Kozlyuk , talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, david.marchand@redhat.com, arybchenko@solarflare.com, bruce.richardson@intel.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com, konstantin.ananyev@intel.com Message-ID: <20200611114316.GA12564@platinum> References: <20200519184111.4504-1-talshn@mellanox.com> <3106438.CAdn2TfLgq@thomas> <20200519225753.56c663ac@sovereign> <1935350.G7KYNPxu0G@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] mbuf: align rte_mbuf for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 19, 2020 at 03:15:19PM -0700, Ranjit Menon wrote: > On 5/19/2020 1:18 PM, Thomas Monjalon wrote: > > 19/05/2020 21:57, Dmitry Kozlyuk: > > > On Tue, 19 May 2020 20:49:50 +0200 > > > Thomas Monjalon wrote: > > > > > > > +Cc more maintainers > > > > > > > > 19/05/2020 20:41, talshn@mellanox.com: > > > > > From: Tal Shnaiderman > > > > > > > > > > Using uint32_t type bit-fields in Windows will pads the > > > > > 'L2/L3/L4 and tunnel information' union with additional bits. > > > > > > > > > > This padding causes rte_mbuf size misalignment and the total size > > > > > increases to 3 cache-lines. > > > > > > > > > > Changed packet_type bit-fields types from uint32_t to uint8_t > > > > > to allow unified 2 cache-line structure size. > > > > > > > > > > Added the __extension__ attribute over the modified struct to avoid > > > > > the warning: > > > > > > > > > > type of bit-field ... is a GCC extension [-pedantic] > > > > > > > > > > Signed-off-by: Tal Shnaiderman Acked-by: Olivier Matz