From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1139AA00BE;
	Thu, 11 Jun 2020 22:18:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 465F6E07;
	Thu, 11 Jun 2020 22:18:39 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 151943B5
 for <dev@dpdk.org>; Thu, 11 Jun 2020 22:18:38 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 547FE20B7192; Thu, 11 Jun 2020 13:18:37 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 547FE20B7192
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1591906717;
 bh=UpE30090fzEyd/AXpo5hdyih59GU680Irq3is89jit0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=awPu2uNjKnLvKoifZhFYlj8EM5W24hIUXmJCq057vPNmpGu2lpaMGce0M//vJEVX4
 5m0KL1cGLNWIqdvZi0rM6JKWf9Yfq2zClZ3+CGRQEYp2/EcCN3aDReWem2NtUrBOHQ
 MNNJluJbpus62rpHSTTX0uKcELE4xn94arpuJFFA=
Date: Thu, 11 Jun 2020 13:18:37 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
 dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com,
 tbashar@mellanox.com, Harini.Ramakrishnan@microsoft.com,
 talshn@mellanox.com, fady@mellanox.com, ocardona@microsoft.com
Message-ID: <20200611201837.GA42520@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200528231455.13636-1-pallavi.kadam@intel.com>
 <20200611195055.3024-1-pallavi.kadam@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200611195055.3024-1-pallavi.kadam@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v4] eal: fix warnings on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 11, 2020 at 12:50:55PM -0700, Pallavi Kadam wrote:
> Fixed bunch of warnings when compiling using clang on Windows
> such as the use of an unsafe string function (strerror),
> [-Wunused-variable], [-Wunused-function] in eal_common_options.c
> [-Wunused-const-variable] in getopt.c and [-Wunused-parameter]
> in eal_common_thread.c.
> Also fixed warnings generated using Mingw:
> [-Werror=old-style-definition], [-Werror=cast-function-type] and
> [-Werror=attributes]
> 
> v4 changes:
> 	Removed -Werror that was added on Windows in v3
> 	Removed self 'Tested-by' line
> 
> v3 changes:
> 	Fixed pthread warning
> 	Added -Werror on Windows
> 	Fixed MinGW warnings
> 
> v2 changes:
> 	Excluded dirent.h file on Windows temporarily.
> 	(This file will stay on Windows for later use)
> 
> Signed-off-by: Ranjit Menon <ranjit.menon@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
Tested with clang, no warnings generated.
Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>