From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D01A00BE; Fri, 12 Jun 2020 05:48:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0ED11BF53; Fri, 12 Jun 2020 05:46:35 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 098491BEE6 for ; Fri, 12 Jun 2020 05:46:32 +0200 (CEST) IronPort-SDR: 6HKqCjd6IlIf4omdQiJaR+Gzqzyp3kDjIYhSFQkp2dpvJxPh9F1NC63KV2smLGELHuYaTrVR45 aFSQW95XjACw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 20:46:32 -0700 IronPort-SDR: uNqAKE4wpsdV3R7SiQsO8hlSWa/YEb3gGS+yG4LNqP/0ifm9XZCS+b627sDtf9gEyXZ8ManaA2 +ngC5efCWprg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="289759583" Received: from intel.sh.intel.com ([10.239.255.18]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:31 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Guinan Sun , Zalfresso-Jundzillo Date: Fri, 12 Jun 2020 03:24:04 +0000 Message-Id: <20200612032410.20864-16-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200612032410.20864-1-guinanx.sun@intel.com> References: <20200612032410.20864-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH 15/21] net/ixgbe/base: remove unnecessary log message FC autonego X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function ixgbe_device_supports_autoneg_fc is checking whether a particular device and medium configuration is supporting Flow Control Autonegotiation. In case of non-support, the message is always logged which is confusing. The fix is removing unnecessary log entry. Signed-off-by: Zalfresso-Jundzillo Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_common.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index c4e99d876..4a3b48b39 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -187,10 +187,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw) break; } - if (!supported) - ERROR_REPORT2(IXGBE_ERROR_UNSUPPORTED, - "Device %x does not support flow control autoneg", - hw->device_id); return supported; } -- 2.17.1