From: "Gaëtan Rivet" <grive@u256.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, matan@mellanox.com, xiao.w.wang@intel.com,
zhihong.wang@intel.com, xiaolong.ye@intel.com,
chenbo.xia@intel.com, david.marchand@redhat.com,
amorenoz@redhat.com, shreyansh.jain@nxp.com,
viacheslavo@mellanox.com, hemant.agrawal@nxp.com,
sachin.saxena@nxp.com
Subject: Re: [dpdk-dev] [PATCH 00/14] vDPA API and framework rework
Date: Fri, 12 Jun 2020 11:38:29 +0200 [thread overview]
Message-ID: <20200612093829.6l43srtrbi7sdbfe@u256.net> (raw)
In-Reply-To: <20200611213748.1967029-1-maxime.coquelin@redhat.com>
Hello Maxime,
On 11/06/20 23:37 +0200, Maxime Coquelin wrote:
> This series aims to rework the vDPA framework and
> its API to better fit into the DPDK device model
> and also be more easily consumable by applications.
>
> Main changes are creating a device class for vDPA,
> which enables applications to iterate vDPA devices
> in a generic way:
>
> RTE_DEV_FOREACH(dev, "class=vdpa", it) {...}
>
That's neat, I was wondering if the class layer would become useful
someday.
> Also the notion of vDPA device ID is replaced
> with both application & drivers using the
> rte_vdpa_device as reference. Doing that also
> made possible to store devices references into
> a linked list instead of a static array. Last
> patch makes the rte_vdpa_device structure
> content opaque to the applications, creating
> a clear barrier between application visible
> API and drivers visble ones.
>
> The first two patches fixes issues in some
> busses iterators, causing segmentation faults
> when iterating only on a device class.
>
> While reviewing, if you notice further possible
> improvements, please let me know. Target is to
> remove the experimental tag from vDPA APIs in
> next LTS release.
>
> Thanks to David for giving me some ideas of
> improvements!
>
I can't really comment on vhost parts and vdpa implems,
but overall this seems a good idea to me.
> Maxime Coquelin (14):
> bus/dpaa: fix null pointer dereference
> bus/fslmc: fix null pointer dereference
> vhost: introduce vDPA devices class
> vhost: make vDPA framework bus agnostic
> vhost: replace device ID in vDPA ops
> vhost: replace vDPA device ID in Vhost
> vhost: replace device ID in applications
> vhost: remove useless vDPA API
> vhost: use linked-list for vDPA devices
> vhost: introduce wrappers for some vDPA ops
> examples/vdpa: use new wrappers instead of ops
> examples/vdpa: remove useless device count
> vhost: remove vDPA device count API
> vhost: split vDPA header file
>
> drivers/bus/dpaa/dpaa_bus.c | 5 +
> drivers/bus/fslmc/fslmc_bus.c | 5 +
> drivers/vdpa/ifc/ifcvf_vdpa.c | 84 ++++-----
> drivers/vdpa/mlx5/mlx5_vdpa.c | 85 +++++----
> drivers/vdpa/mlx5/mlx5_vdpa.h | 5 +-
> examples/vdpa/main.c | 108 +++++------
> lib/librte_vhost/Makefile | 3 +-
> lib/librte_vhost/meson.build | 3 +-
> lib/librte_vhost/rte_vdpa.h | 172 ++++--------------
> lib/librte_vhost/rte_vdpa_dev.h | 135 ++++++++++++++
> lib/librte_vhost/rte_vhost.h | 20 ++-
> lib/librte_vhost/rte_vhost_version.map | 11 +-
> lib/librte_vhost/socket.c | 48 ++---
> lib/librte_vhost/vdpa.c | 238 ++++++++++++++++---------
> lib/librte_vhost/vhost.c | 19 +-
> lib/librte_vhost/vhost.h | 9 +-
> lib/librte_vhost/vhost_user.c | 28 +--
> 17 files changed, 545 insertions(+), 433 deletions(-)
> create mode 100644 lib/librte_vhost/rte_vdpa_dev.h
>
> --
> 2.26.2
>
--
Gaëtan
prev parent reply other threads:[~2020-06-12 9:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 21:37 Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 01/14] bus/dpaa: fix null pointer dereference Maxime Coquelin
2020-06-12 9:48 ` Gaëtan Rivet
2020-06-11 21:37 ` [dpdk-dev] [PATCH 02/14] bus/fslmc: " Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 03/14] vhost: introduce vDPA devices class Maxime Coquelin
2020-06-12 12:37 ` Gaëtan Rivet
2020-06-15 9:15 ` Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 04/14] vhost: make vDPA framework bus agnostic Maxime Coquelin
2020-06-12 12:46 ` Gaëtan Rivet
2020-06-15 9:17 ` Maxime Coquelin
2020-06-19 11:14 ` Adrian Moreno
2020-06-19 15:11 ` Maxime Coquelin
2020-06-22 9:49 ` Adrian Moreno
2020-06-22 12:34 ` Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 05/14] vhost: replace device ID in vDPA ops Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 06/14] vhost: replace vDPA device ID in Vhost Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 07/14] vhost: replace device ID in applications Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 08/14] vhost: remove useless vDPA API Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 09/14] vhost: use linked-list for vDPA devices Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 10/14] vhost: introduce wrappers for some vDPA ops Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 11/14] examples/vdpa: use new wrappers instead of ops Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 12/14] examples/vdpa: remove useless device count Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 13/14] vhost: remove vDPA device count API Maxime Coquelin
2020-06-11 21:37 ` [dpdk-dev] [PATCH 14/14] vhost: split vDPA header file Maxime Coquelin
2020-06-12 9:38 ` Gaëtan Rivet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612093829.6l43srtrbi7sdbfe@u256.net \
--to=grive@u256.net \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=sachin.saxena@nxp.com \
--cc=shreyansh.jain@nxp.com \
--cc=viacheslavo@mellanox.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).