From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B089FA04A3; Tue, 16 Jun 2020 11:26:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07D241BED0; Tue, 16 Jun 2020 11:26:17 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id DEF9E1BEC5 for ; Tue, 16 Jun 2020 11:26:15 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id d7so11314058lfi.12 for ; Tue, 16 Jun 2020 02:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MgnzwNSOnVQ2LcDoHWXjzz03eHuuQCfWAOSahIXtNVE=; b=gYFx03Zr1XRqKYWjdYJH2vyFJu1yLoJtlZxRHoMqhEXgcN0/zQD8S/Qa/XmQzer6tb B5di4hWdubGqWgFvB4oMaxBMLtrrpFXGfMhOylWvqXOjgIX5zUy609984FOnqgWH7gSV WrKVc7XIjEW2cKpL8MUWzGZNiZ/wglZhKbv6AbUwX9R16aqPsLv7r7N6fgPf6XQUSWKG GKQGU9kFQCCYdhNwF6ngMBLUYCVufIjz5DAqVsUITMBFzbTgMBcVcHEGehGsS+LILMsF QjdB4hTswHn/bEDRqqXUwR3Mplc1G7FGz4aUKPHqz2Uwit01XGtWLge/Z3vo+rOzmEce K2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MgnzwNSOnVQ2LcDoHWXjzz03eHuuQCfWAOSahIXtNVE=; b=dZqlGDwOCqoc4phoPBx3bhxJeF0nFu1XzkDNuP2QiUODejrNT+9dlx2FxB4UHWZT+r hCyDrecXKNlT7yrm39nu7E1RgPyULbN+ezdaUJj4jVRD/UQ+GQpFQC65B2et/8JXzgmd uwyKRUoYYSqDpERowVfvkZ9ZxGL43e4Jf0AqcWLcH93dQlFMfzTQKmCcIQ0/ic/zcAIH Fgcwp/ax7M74eh+OKM/h7Fe4dJWEEHJfkbd6S9sW1Og9CalQEDZWxmlnA/AwufbFkeAP xQZ0UlgIvgnSRNgWdEqXrOngGWh2O26x0Elg02uVw1d5l3TnyBG7Jr2nLC8r19W/nXpS Wufw== X-Gm-Message-State: AOAM530fVtNKeyGPtg6aKcde3Q02gafGjEzKtoDff45Enr/N9tCRYMlp esnWBjW/j1SNPiarwJuBWPo= X-Google-Smtp-Source: ABdhPJzS1PF/pnQVjSKACuV4jzTB7402f2yCsYvqBiEs6HMTvoP5wjPVKXoXgshuyDYJTeh3BSTIrQ== X-Received: by 2002:a19:ac08:: with SMTP id g8mr1253479lfc.207.1592299575233; Tue, 16 Jun 2020 02:26:15 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id o201sm699515lff.8.2020.06.16.02.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 02:26:14 -0700 (PDT) Date: Tue, 16 Jun 2020 12:26:13 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: Tal Shnaiderman , dev@dpdk.org, "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , Fady Bader , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" Message-ID: <20200616122613.3aa4c836@sovereign> In-Reply-To: <18516284.rRsmoNJoJ4@thomas> References: <20200601093818.5420-1-talshn@mellanox.com> <2493055.5tyvKvVbxn@thomas> <18516284.rRsmoNJoJ4@thomas> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 16 Jun 2020 10:45:49 +0200 Thomas Monjalon wrote: > 16/06/2020 10:33, Tal Shnaiderman: > > > 01/06/2020 11:38, talshn@mellanox.com: > > > > From: Tal Shnaiderman > > > > > > > > Export needed eal functions used by the lib. > > > > > > > > Signed-off-by: Tal Shnaiderman > > > > --- > > > > --- a/lib/librte_eal/rte_eal_exports.def > > > > +++ b/lib/librte_eal/rte_eal_exports.def > > > > @@ -3,6 +3,7 @@ EXPORTS > > > > per_lcore__rte_errno > > > > rte_calloc > > > > rte_calloc_socket > > > > + per_lcore__lcore_id > > > [...] > > > > --- a/lib/librte_eal/rte_eal_version.map > > > > +++ b/lib/librte_eal/rte_eal_version.map > > > > @@ -394,4 +394,5 @@ EXPERIMENTAL { > > > > rte_mem_unmap; > > > > __emutls_v.per_lcore__rte_errno; > > > > __rte_trace_mem_per_thread_alloc; > > > > + __emutls_v.per_lcore__lcore_id; > > Note the alphabetical order is not respected above. > > > > I'm surprised about this one in the Linux/BSD map. > > > Can it be removed? > > > > It is needed for the MingGW build which requires the __emutls_v. prefix. > > We already have per_lcore__lcore_id and per_lcore__rte_errno > for Linux and FreeBSD. > The prefix __emutls_v. for MinGW looks wrong. > If it is really required, it should be added automatically > in my opinion. > I think we can do it in buildtools/map_to_def.py > by adding this prefix to per_lcore__ when required. MinGW doesn't use .def, it's for link.exe only (used by Clang). To my understanding, multiple .map files can be used [1]. The "overlay .map" for MinGW can then be generated from the generic .map by a separate script. [1]: https://github.com/PlushBeaver/dpdk/blob/windows/lib/meson.build#L174 -- Dmitry Kozlyuk