DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tal Shnaiderman <talshn@mellanox.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"harini.ramakrishnan@microsoft.com"
	<harini.ramakrishnan@microsoft.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] MinGW guide
Date: Wed, 17 Jun 2020 00:34:00 +0300	[thread overview]
Message-ID: <20200617003400.4fcbbce4@sovereign> (raw)
In-Reply-To: <AM0PR05MB53138CD01A5006AB6ECEC8F4A99C0@AM0PR05MB5313.eurprd05.prod.outlook.com>

On Mon, 15 Jun 2020 09:25:07 +0000
Tal Shnaiderman <talshn@mellanox.com> wrote:

> > Subject: Re: MinGW guide
> > 
> > On Sat, 13 Jun 2020 10:55:14 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:  
> 
> [snip]
> 
> > > Then when installing mingw-w64-install.exe, a choice must be done
> > > between threads POSIX or Win32.
> > > If I understand well, POSIX must be chosen?  
> > 
> > Yes. DPDK config/meson.build now links with pthread if linker is not link.exe.
> >   
> 
> Where do we actually use pthread in Windows?

Nowhere indeed. Probably it was my mistake to link with it when adding MinGW
support. Shim is always used anyway.

> 
> > Note that maybe this can be relaxed (test needed!), i. e. link with pthread if
> > it is found, otherwise use shim. Benefit, if this works: no runtime
> > dependency on "libwinpthread-1.dll" for Windows.  
> 
> I was sure, since we create the threads with Win32 API (CreateThread), the correct option is Win32.
> My mingw-w64 is installed with that option and I didn't see issues with it.

Then I'm totally wrong. Your way MinGW-w64 produces an executable without
dependencies (apart from system libraries), so this should be preferred. I
tried and it works for me.

-- 
Dmitry Kozlyuk

      reply	other threads:[~2020-06-16 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13  8:55 Thomas Monjalon
2020-06-15  0:48 ` Dmitry Kozlyuk
2020-06-15  9:25   ` Tal Shnaiderman
2020-06-16 21:34     ` Dmitry Kozlyuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617003400.4fcbbce4@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=harini.ramakrishnan@microsoft.com \
    --cc=talshn@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).