From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7DF1A04A5; Wed, 17 Jun 2020 10:15:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BDC11252; Wed, 17 Jun 2020 10:15:27 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 017721150 for ; Wed, 17 Jun 2020 10:15:25 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from fady@mellanox.com) with SMTP; 17 Jun 2020 11:15:23 +0300 Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 05H8FNBO026882; Wed, 17 Jun 2020 11:15:23 +0300 From: Fady Bader To: dev@dpdk.org Cc: talshn@mellanox.com, fady@mellanox.com, thomasm@mellanox.com, tbashar@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, cristian.dumitrescu@intel.com, stable@dpdk.org Date: Wed, 17 Jun 2020 11:15:07 +0300 Message-Id: <20200617081507.22868-1-fady@mellanox.com> X-Mailer: git-send-email 2.16.1.windows.4 Subject: [dpdk-dev] [PATCH] meter: remove inline functions from export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The code didn't compile when using exported meter functions under windows. error LNK2001: unresolved external symbol rte_meter_srtcm_color_aware_check error LNK2001: unresolved external symbol rte_meter_srtcm_color_blind_check error LNK2001: unresolved external symbol rte_meter_trtcm_color_aware_check error LNK2001: unresolved external symbol rte_meter_trtcm_color_blind_check error LNK2001: unresolved external symbol rte_meter_trtcm_rfc4115_color_aware_check error LNK2001: unresolved external symbol rte_meter_trtcm_rfc4115_color_blind_check The cause was that there were some inline functions that were included in the export list. To solve this the functions were removed from rte_meter_version.map export list which are implemented in the header and shouldn't be exported. Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM") Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning") Cc: stable@dpdk.org Signed-off-by: Fady Bader --- lib/librte_meter/rte_meter_version.map | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map index b493bcebe9..58859d4d76 100644 --- a/lib/librte_meter/rte_meter_version.map +++ b/lib/librte_meter/rte_meter_version.map @@ -1,12 +1,8 @@ DPDK_20.0 { global: - rte_meter_srtcm_color_aware_check; - rte_meter_srtcm_color_blind_check; rte_meter_srtcm_config; rte_meter_srtcm_profile_config; - rte_meter_trtcm_color_aware_check; - rte_meter_trtcm_color_blind_check; rte_meter_trtcm_config; rte_meter_trtcm_profile_config; @@ -16,8 +12,6 @@ DPDK_20.0 { DPDK_21 { global: - rte_meter_trtcm_rfc4115_color_aware_check; - rte_meter_trtcm_rfc4115_color_blind_check; rte_meter_trtcm_rfc4115_config; rte_meter_trtcm_rfc4115_profile_config; -- 2.16.1.windows.4