From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A153AA04A5;
Wed, 17 Jun 2020 16:44:06 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 72BA31B3BB;
Wed, 17 Jun 2020 16:43:51 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 4EC09AAD5;
Wed, 17 Jun 2020 16:43:49 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D643131B;
Wed, 17 Jun 2020 07:43:48 -0700 (PDT)
Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com
[10.118.12.27])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB2C43F73C;
Wed, 17 Jun 2020 07:43:48 -0700 (PDT)
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: dev@dpdk.org, honnappa.nagarahalli@arm.com, alialnu@mellanox.com,
orgerlitz@mellanox.com, wenzhuo.lu@intel.com, beilei.xing@intel.com,
bernard.iremonger@intel.com
Cc: hemant.agrawal@nxp.com, jerinj@marvell.com, viacheslavo@mellanox.com,
thomas@monjalon.net, ruifeng.wang@arm.com, phil.yang@arm.com, nd@arm.com,
stable@dpdk.org
Date: Wed, 17 Jun 2020 09:43:06 -0500
Message-Id: <20200617144307.9961-4-honnappa.nagarahalli@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200617144307.9961-1-honnappa.nagarahalli@arm.com>
References: <20200617144307.9961-1-honnappa.nagarahalli@arm.com>
Subject: [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The burst % calculation can over flow due to multiplication.
Fix the multiplication and increase the size of variables to
64b.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test-pmd/testpmd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 4989d22ca..2e1493da2 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1692,9 +1692,9 @@ init_fwd_streams(void)
static void
pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
{
- unsigned int total_burst;
- unsigned int nb_burst;
- unsigned int burst_stats[3];
+ uint64_t total_burst;
+ uint64_t nb_burst;
+ uint64_t burst_stats[3];
uint16_t pktnb_stats[3];
uint16_t nb_pkt;
int burst_percent[3];
@@ -1723,8 +1723,8 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
}
if (total_burst == 0)
return;
- burst_percent[0] = (burst_stats[0] * 100) / total_burst;
- printf(" %s-bursts : %u [%d%% of %d pkts", rx_tx, total_burst,
+ burst_percent[0] = (double)burst_stats[0] / total_burst * 100;
+ printf(" %s-bursts : %"PRIu64" [%d%% of %d pkts", rx_tx, total_burst,
burst_percent[0], (int) pktnb_stats[0]);
if (burst_stats[0] == total_burst) {
printf("]\n");
@@ -1735,7 +1735,7 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
100 - burst_percent[0], pktnb_stats[1]);
return;
}
- burst_percent[1] = (burst_stats[1] * 100) / total_burst;
+ burst_percent[1] = (double)burst_stats[1] / total_burst * 100;
burst_percent[2] = 100 - (burst_percent[0] + burst_percent[1]);
if ((burst_percent[1] == 0) || (burst_percent[2] == 0)) {
printf(" + %d%% of others]\n", 100 - burst_percent[0]);
--
2.17.1