Re: [dpdk-dev] [PATCH v5 7/8] bus/pci: introduce Windows support with stubs

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

[snip]
> @@ -345,3 +352,21 @@ rte_eal_init(int argc, char **argv)
>  	rte_eal_mp_wait_lcore();
>  	return fctret;
>  }
> +
> +int
> +rte_vfio_container_dma_map(__rte_unused int container_fd,
> +			__rte_unused uint64_t vaddr,
> +			__rte_unused uint64_t iova,
> +			__rte_unused uint64_t len)
> +{
> +	return -1;
> +}
> +
> +int
> +rte_vfio_container_dma_unmap(__rte_unused int container_fd,
> +			__rte_unused uint64_t vaddr,
> +			__rte_unused uint64_t iova,
> +			__rte_unused uint64_t len)
> +{
> +	return -1;
> +}
> diff --git a/lib/librte_eal/windows/eal_mp.c b/lib/librte_eal/windows/eal_mp.c
> index 16a5e8ba03..70061bea03 100644
> --- a/lib/librte_eal/windows/eal_mp.c
> +++ b/lib/librte_eal/windows/eal_mp.c
> @@ -101,3 +101,17 @@ request_sync(void)
>  	EAL_LOG_STUB();
>  	return 0;
>  }
> +
> +int
> +eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
> +{
> +	RTE_SET_USED(req);
> +	return 0;
> +}
> +
> +int
> +eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
> +{
> +	RTE_SET_USED(req);
> +	return 0;
> +}

You should add relevant #includes or declarations to prevent the following
warnings:

[30/64] Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_windows_eal.c.obj'
../../../../../lib/librte_eal/windows/eal.c:360:1: warning: no previous prototype for 'rte_vfio_container_dma_map' [-Wmissing-prototypes]
  360 | rte_vfio_container_dma_map(__rte_unused int container_fd,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../lib/librte_eal/windows/eal.c:369:1: warning: no previous prototype for 'rte_vfio_container_dma_unmap' [-Wmissing-prototypes]
  369 | rte_vfio_container_dma_unmap(__rte_unused int container_fd,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[44/64] Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_windows_eal_mp.c.obj'
../../../../../lib/librte_eal/windows/eal_mp.c:106:43: warning: 'struct eal_dev_mp_req' declared inside parameter list will not be visible outside of this definition or declaration
  106 | eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
      |                                           ^~~~~~~~~~~~~~
../../../../../lib/librte_eal/windows/eal_mp.c:106:1: warning: no previous prototype for 'eal_dev_hotplug_request_to_primary' [-Wmissing-prototypes]
  106 | eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../lib/librte_eal/windows/eal_mp.c:113:45: warning: 'struct eal_dev_mp_req' declared inside parameter list will not be visible outside of this definition or declaration
  113 | eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
      |                                             ^~~~~~~~~~~~~~
../../../../../lib/librte_eal/windows/eal_mp.c:113:1: warning: no previous prototype for 'eal_dev_hotplug_request_to_secondary' [-Wmissing-prototypes]
  113 | eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-- 
Dmitry Kozlyuk