From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18CD2A04A5; Wed, 17 Jun 2020 22:29:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E51B72BF4; Wed, 17 Jun 2020 22:29:41 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 3DC1D29C6 for ; Wed, 17 Jun 2020 22:29:40 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id q19so4557737lji.2 for ; Wed, 17 Jun 2020 13:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=26ndrpzw1JTeAQi48Lt1H2eNYD0CEzDnQiLtR0xhOLo=; b=nNVQdy4gjroMU7GYu1qXF0LLitjF12gy5E1PVXf5HQCMdoMJRnyfprKpGOOLba+rv9 IqHvYLfhPqzzG3eo4YDgDT2pQcoF+8EeEfJO4kpnMoAET5R3CIeuS3kU+4A3S/fwff3z loMftn0hlZUzrU5AYMYM8cZSa8In5a3a1StAJe3mPKlgjRdiBNjCLz+IP/CgQs/6HLVp iD0DmaIcl+S9AEK6Oe7pbteyuuE2gzI1g76eO04ESy4AYUBIgDUDzbkpO0ljaK2KOKx7 NJlwQOb5LrijxxMbrbi07HONo+tzD8A4BXX8bqnVmeo32ZApH8e2gxrBkicbAWYpkaMs mjZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=26ndrpzw1JTeAQi48Lt1H2eNYD0CEzDnQiLtR0xhOLo=; b=Tbc2NMaQBiZrvaWgMiGaAnkgHYaJqkiBWzaVpogOGDLlTSSEe45TUg7vYNZG6/adGj qzuaVGgkfNFkr18kTolJFXQlCFMDGT9IKcD5piD5o/DkFoXFFkTXNmIOpdYUuMEH1aY4 0apSWAwskok0o6lIQVgY3rCEMPGkAipdiCuMzrKKdbPquWCLVgeek/MMtMZJS1t68By9 FXn3tYLPlisF+nzNQ2nExTgZVku4GmePJ5UnjhCfvcQuhBsbmWse6im8pWY7TEjt1cGV cZNPSYCWEAqyn/ItXN6uIJxCwTGp0HLJ2Ai/AaQ3RJv39ZcPndiu7fpUS9u6tQs/yKpm y34w== X-Gm-Message-State: AOAM530Im11B8f4x6lUVKLCMMkE3ztCiiVQOtcLijgvgJsxZUSxJc8oz Ty4TPxcviCuphYN6O/+tNQk= X-Google-Smtp-Source: ABdhPJyCGXDLjfZGq/VUP6eEx1yqWYTnjH1Xs/f41HDZ5Q1ayTX8uWZaatf+hyMkjG8olVEsiwKb7g== X-Received: by 2002:a2e:2281:: with SMTP id i123mr470358lji.113.1592425779874; Wed, 17 Jun 2020 13:29:39 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z2sm186205ljh.72.2020.06.17.13.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 13:29:39 -0700 (PDT) Date: Wed, 17 Jun 2020 23:29:38 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com Message-ID: <20200617232938.7d96bf31@sovereign> In-Reply-To: <20200609103139.22168-8-talshn@mellanox.com> References: <20200609103139.22168-1-talshn@mellanox.com> <20200609103139.22168-8-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 7/8] bus/pci: introduce Windows support with stubs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [snip] > @@ -345,3 +352,21 @@ rte_eal_init(int argc, char **argv) > rte_eal_mp_wait_lcore(); > return fctret; > } > + > +int > +rte_vfio_container_dma_map(__rte_unused int container_fd, > + __rte_unused uint64_t vaddr, > + __rte_unused uint64_t iova, > + __rte_unused uint64_t len) > +{ > + return -1; > +} > + > +int > +rte_vfio_container_dma_unmap(__rte_unused int container_fd, > + __rte_unused uint64_t vaddr, > + __rte_unused uint64_t iova, > + __rte_unused uint64_t len) > +{ > + return -1; > +} > diff --git a/lib/librte_eal/windows/eal_mp.c b/lib/librte_eal/windows/eal_mp.c > index 16a5e8ba03..70061bea03 100644 > --- a/lib/librte_eal/windows/eal_mp.c > +++ b/lib/librte_eal/windows/eal_mp.c > @@ -101,3 +101,17 @@ request_sync(void) > EAL_LOG_STUB(); > return 0; > } > + > +int > +eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) > +{ > + RTE_SET_USED(req); > + return 0; > +} > + > +int > +eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req) > +{ > + RTE_SET_USED(req); > + return 0; > +} You should add relevant #includes or declarations to prevent the following warnings: [30/64] Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_windows_eal.c.obj' ../../../../../lib/librte_eal/windows/eal.c:360:1: warning: no previous prototype for 'rte_vfio_container_dma_map' [-Wmissing-prototypes] 360 | rte_vfio_container_dma_map(__rte_unused int container_fd, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../../lib/librte_eal/windows/eal.c:369:1: warning: no previous prototype for 'rte_vfio_container_dma_unmap' [-Wmissing-prototypes] 369 | rte_vfio_container_dma_unmap(__rte_unused int container_fd, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ [44/64] Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_windows_eal_mp.c.obj' ../../../../../lib/librte_eal/windows/eal_mp.c:106:43: warning: 'struct eal_dev_mp_req' declared inside parameter list will not be visible outside of this definition or declaration 106 | eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) | ^~~~~~~~~~~~~~ ../../../../../lib/librte_eal/windows/eal_mp.c:106:1: warning: no previous prototype for 'eal_dev_hotplug_request_to_primary' [-Wmissing-prototypes] 106 | eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../../lib/librte_eal/windows/eal_mp.c:113:45: warning: 'struct eal_dev_mp_req' declared inside parameter list will not be visible outside of this definition or declaration 113 | eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req) | ^~~~~~~~~~~~~~ ../../../../../lib/librte_eal/windows/eal_mp.c:113:1: warning: no previous prototype for 'eal_dev_hotplug_request_to_secondary' [-Wmissing-prototypes] 113 | eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Dmitry Kozlyuk