From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DCB0A04A5; Wed, 17 Jun 2020 22:39:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42DD61252; Wed, 17 Jun 2020 22:39:30 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 905F4FFA for ; Wed, 17 Jun 2020 22:39:28 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id x18so4581720lji.1 for ; Wed, 17 Jun 2020 13:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m84nOpCbuKEdGXUJeR/Aa41hozyhOC2pedHpsUAayAM=; b=C1GBa/uMRlJhbm2DvJ6VA2CvFHYSQ2mLAPTyhwd50euBFtTF0czYRUZ9+wbKkuKkZU ZS51LM9gMM+aZ3x+tAKAr3U0haGBXmISdbtwQUB1ERHjABPdaKdmrO6pt4BSeVipLxMT L04Tu/O8ReXJdie3oiVXYP+MfRLbWXZN6pdGd1ka2Z6SR9lD8if8BGMtMOvqqXoqlEAU OZXe50tq1gQf6sDfpXdiXMbDoB4LNQe6I76qtr2HaXVyeWSKlhfaN0oYaGXpGPjlddcp BQweOcZsSpNDfYDLPoCjWU0CgK8VHZtz/eu+3nVBTh/nMYhE+1zrmNXxJhcHOFt74XuE s3sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m84nOpCbuKEdGXUJeR/Aa41hozyhOC2pedHpsUAayAM=; b=edp9vaST1cKr64jkORuqCS78dR3ucSH488u2RhiBl3/IcIT4G34NW3tfp5+MZZVetp OwwEj4QUWZ9iQxtE8TcpNcwOoRN4AF/OCrtgIDW1miqq1lxJacc9PTlRmrdpqR7yu3wn TUMs/EgmurcUWbWH1JKxH8lUGpkt99b7jMYYbUMf6hMapC90UeV8+8CFC26v9asc2Hde 9efVLCC1cHVkdNPYdiewxXRatOdjwzB9eBTrN7yf8z/ZZM3YE6vhSsTM/yXyikp3AqeL S+fHKvl6aa6Fz6nB2PYlYviSXDBndpRvKsOiw+dlOopgi3wFzuLEQJ34jDMLmK3Y/dWt dX0A== X-Gm-Message-State: AOAM530mlTpyWeyiAbunpE0DxnVbrs9BMQbUe7sZ5bq+dEv15CEq9NBO 4y5WG49uH1mEKK8ieVnus3w= X-Google-Smtp-Source: ABdhPJwloQRuG+qeboR9IBxmy0exZPyh2oUB25atlExv/BqA2Ytr9qyJIcYXR0d3pOeYfTNKoAHf7g== X-Received: by 2002:a2e:b4eb:: with SMTP id s11mr542722ljm.452.1592426368107; Wed, 17 Jun 2020 13:39:28 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id y3sm167892ljk.39.2020.06.17.13.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 13:39:27 -0700 (PDT) Date: Wed, 17 Jun 2020 23:39:26 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com Message-ID: <20200617233926.3d45c35e@sovereign> In-Reply-To: <20200609103139.22168-6-talshn@mellanox.com> References: <20200609103139.22168-1-talshn@mellanox.com> <20200609103139.22168-6-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 5/8] drivers: ignore pmdinfogen generation for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 9 Jun 2020 13:31:36 +0300 talshn@mellanox.com wrote: > From: Tal Shnaiderman > > pmdinfogen generation is currently unsupported for Windows. > The relevant part in meson.build is skipped. > > Signed-off-by: Tal Shnaiderman > --- > drivers/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/meson.build b/drivers/meson.build > index cfb6a833c9..a7eac86790 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -107,6 +107,7 @@ foreach class:dpdk_driver_classes > > dpdk_extra_ldflags += pkgconfig_extra_libs > > + if host_machine.system() != 'windows' > # generate pmdinfo sources by building a temporary > # lib and then running pmdinfogen on the contents of > # that lib. The final lib reuses the object files and > @@ -123,7 +124,7 @@ foreach class:dpdk_driver_classes > '@OUTPUT@', pmdinfogen], > output: out_filename, > depends: [pmdinfogen, tmp_lib]) > - > + endif > version_map = '@0@/@1@/@2@_version.map'.format( > meson.current_source_dir(), > drv_path, lib_name) Lack of indentation here is misleading. If you move the comment above "if", there's not much to rewrap inside after indenting. -- Dmitry Kozlyuk