From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C99BA04A5; Thu, 18 Jun 2020 02:43:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80D821B75C; Thu, 18 Jun 2020 02:42:51 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 816201B75C for ; Thu, 18 Jun 2020 02:42:50 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 365415C0049; Wed, 17 Jun 2020 20:42:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 17 Jun 2020 20:42:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=iwvnSHhSCKR5w Q9Ap082evOr2ZF4WsPImbjLoP550oM=; b=nvqY8hixT1FEpT5ooEWJkwcx17Iua 2uAActY/xGxJSjYNP37e5q77En/FkVpQDgx4ZJu0t3u+u4XvGTToq7utScocfzrS aJd3lQ+xGKaErsZIE0GYvzAmx65MK2xf7aDpY67Fp5T241Adju3rf71QEJy5GnOi ssHRds+7r6FA/qlOZFW9anpJe/XPCRGlr8SkkQf+tmQk7OXpg69+wgSw6iAEs7NV aFC5W/2Qp84lTortqHRTPYtuSM9ccO+r7Hsu5XNUntsxJd4p/e+DuQ9gkGLKPr7O kSW1lu3cucow6Peoz8bYvUawNYfTTq94w9BdINtLh8wPExeuKJ4BqGK8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=iwvnSHhSCKR5wQ9Ap082evOr2ZF4WsPImbjLoP550oM=; b=kXgTkbNX lwFvkEm7C7g2BM0Hbji7feSANXxOcLAMSatd77ZeGw7E+nD13o4LSKW/MqF1ZpXo alNM/ab/qGdcU5vvVvUk3q8IKE1NmSxumF81SDazQmJvnS69FwbgQ6Ic9YjMNKUK GufeGNf+OeAKTXudm0UTz2ZDdi6lfFASDZ5+sHYBg2a7jOSIbfuzOLOdxgPCHfbk 3lLExcyFgINF1tiKf3X3/CSE9tZlJkovjwzEytmNGrMx97xcgjfiA0rpkDcqiHlO V7mce5s4VTVRX+GIduat6tsRa8RqAMO5FkR0+1oE5dIo0KzHkOiMc6klc9YEMUEL IqpWFaatwxh4Yw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejfedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeelleeuvddtheefteeuhe euffevudegjedtkeefueekjeeuhfelkefhheeikefhleenucffohhmrghinhepughpughk rdhorhhgpdhsughktghonhhfihhgrdhmkhdpshgukhhrohhothdrmhhkpdhsughksghuih hlugdrmhhknecukfhppeejjedrvddthedrudegvddruddtgeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (104.142.205.77.rev.sfr.net [77.205.142.104]) by mail.messagingengine.com (Postfix) with ESMTPA id 278F43061856; Wed, 17 Jun 2020 20:42:48 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com Date: Thu, 18 Jun 2020 02:42:18 +0200 Message-Id: <20200618004218.3730743-5-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200618004218.3730743-1-thomas@monjalon.net> References: <20200618004218.3730743-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 4/4] mk: add a paused deprecation warning before each build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" DPDK 20.05 had some deprecation notes after "make config" and after the build. For DPDK 20.08, the config note is replaced with a warning before the config and before the build. After the warning, there is a pause which can be skipped with the variable MAKE_PAUSE. This deprecation process was discussed in the Technical Board: http://mails.dpdk.org/archives/dev/2020-April/162839.html Signed-off-by: Thomas Monjalon --- mk/rte.sdkconfig.mk | 5 ----- mk/rte.sdkroot.mk | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk index 2ea85e4643..f538649f22 100644 --- a/mk/rte.sdkconfig.mk +++ b/mk/rte.sdkconfig.mk @@ -62,11 +62,6 @@ else config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile @echo "Configuration done using" \ $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE))) - @echo "==== NOTE ====" - @echo "It is recommended to build DPDK using 'meson' and 'ninja'" - @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions" - @echo "Building DPDK with 'make' will be deprecated in a future release" - @echo "==============" endif $(RTE_OUTPUT): diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk index 4043a9d4e8..d3b9cdd048 100644 --- a/mk/rte.sdkroot.mk +++ b/mk/rte.sdkroot.mk @@ -60,7 +60,22 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n .PHONY: default test-build default test-build: all +.PHONY: warning +warning: + @echo + @echo "=========================== WARNING ============================" + @echo "It is recommended to build DPDK using 'meson' and 'ninja'" + @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html" + @echo "Building DPDK with 'make' will be deprecated in a future release" + @echo "================================================================" + @echo + @test "$(MAKE_PAUSE)" = n || ( \ + echo "This deprecation warning can be passed by adding MAKE_PAUSE=n"; \ + echo "to 'make' command line or as an exported environment variable."; \ + echo "Press enter to continue..."; read) + .PHONY: config defconfig showconfigs showversion showversionum +config: warning config defconfig showconfigs showversion showversionum: $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ @@ -96,4 +111,5 @@ examples examples_clean: # all other build targets %: $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkroot.mk warning $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ -- 2.26.2