From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA4B4A04F5; Fri, 19 Jun 2020 00:40:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A74B6DE3; Fri, 19 Jun 2020 00:40:21 +0200 (CEST) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id A6646255 for ; Fri, 19 Jun 2020 00:40:20 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id w15so4411569lfe.11 for ; Thu, 18 Jun 2020 15:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=89qocDgtd8DG/3xzBeDhvRhosaGZlfUSzLXDlSfnrv8=; b=q+haPZPOIgW1d9d6Ft4nhjxvv4392DEThEwfs5C/KggOroPXpt4zLHJbmDIZR75qCI Oyhu4dZ/tG7Jx1/mqVcfb4bZ8hVsaxQntiMfMhyQkIJ1QbB5c0yIpzHANs9av//ctlPb 2kqImccNooJyWw0kx1maRa/qTHiiUoV9RdOOcgYB4CEMStV/zsA7r131CB1tb+FAhnaB FODr2Rrs+CAVZXXV+95WrDYuqdjA5n7SIxgH4Rnm5YtIu3MwkHSSWmWkSN5KPPUgEkqr YooMfIWTY3Asou0fqoAi3cUXWPK5wnQbU8UFSHfJ79JlZl1bQ8D3YTEHsOHraOplULjC hBaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=89qocDgtd8DG/3xzBeDhvRhosaGZlfUSzLXDlSfnrv8=; b=AYwrFXIkGeWBUVveZwJQC9otg6yME+NIc6sZyJ2D+wq2hxHB3AvSPZW1E7PsJBdYPy iPoKCy8S/wbwrDrU3104EdI+EZep0Wyj9kU36jAYPCaPwy1wibHb4BcnGLDW2UOGL0tI lQbeJ5Ep24X+86ISvUBpLp6Ug4AdAP/rHppgZiQ7Xv4r1nrJHBPBZyUW8IezfNVcV1bt /1GfbIJUWhH4scwSAau87IOMjKycgzyjrEcLWJusSMuYFbTenGvzmUXxlYykzN0NFHcZ nmyaJcxyWrlnrsARRnFv6S+fzpzSV2JAuPJ+KP4zoceKXst9CJCR7Wirt2UHv3cBghh0 KZGw== X-Gm-Message-State: AOAM530nT8uhqJLOl1Y0t8eUU+zVZWmBkfF64fDbL6XSHyQeO6TF5QTl l5aG8zqcU1Q67LbYRENr1u8= X-Google-Smtp-Source: ABdhPJyI3Dx28CkvP3PBYIGab4V5gXeQuIcHChiFMZWMfFFkx2YPNLabD2DBW8L/k9hIoapjwtQH+Q== X-Received: by 2002:a05:6512:308e:: with SMTP id z14mr261954lfd.29.1592520020181; Thu, 18 Jun 2020 15:40:20 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id r23sm873903ljd.17.2020.06.18.15.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 15:40:19 -0700 (PDT) Date: Fri, 19 Jun 2020 01:40:18 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Message-ID: <20200619014018.6f287bfd@sovereign> In-Reply-To: <20200618211546.24496-9-talshn@mellanox.com> References: <20200609103139.22168-2-talshn@mellanox.com> <20200618211546.24496-1-talshn@mellanox.com> <20200618211546.24496-9-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 8/9] bus/pci: support Windows with bifurcated drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [snip] > +static void > +get_kernel_driver_type(struct rte_pci_device *dev __rte_unused) "dev" is used. > +{ > + /* > + * If another kernel driver is supported the relevant checking > + * functions should be here > + */ > + dev->kdrv = RTE_KDRV_NONE; > +} > + > +static int > +pci_scan_one(HDEVINFO dev_info, PSP_DEVINFO_DATA device_info_data) > +{ > + struct rte_pci_device *dev; > + int ret = -1; > + > + dev = malloc(sizeof(*dev)); > + if (dev == NULL) { > + ret = -1; > + goto end; > + } > + > + memset(dev, 0, sizeof(*dev)); > + > + char pci_device_info[PATH_MAX]; > + BOOL res; > + struct rte_pci_addr addr; > + struct rte_pci_id pci_id; > + > + /* Retrieve PCI device IDs */ > + res = SetupDiGetDeviceRegistryPropertyA(dev_info, device_info_data, > + SPDRP_HARDWAREID, NULL, (BYTE *)&pci_device_info, > + sizeof(pci_device_info), NULL); > + if (!res) { > + RTE_LOG_WIN32_ERR( > + "SetupDiGetDeviceRegistryPropertyA(SPDRP_HARDWAREID)"); > + return -1; "dev" leaks here. [snip] -- Dmitry Kozlyuk