From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F8EA051C; Sat, 20 Jun 2020 20:54:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DF4B1BFA6; Sat, 20 Jun 2020 20:54:37 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id B927B1BFA3 for ; Sat, 20 Jun 2020 20:54:36 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id 9so15083473ljc.8 for ; Sat, 20 Jun 2020 11:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B6C5a8fgXkvGIbXRCUeOuPXtV6lJappdT6WY1SdUJK8=; b=dOd26Tx6Kf6PjBTCzie64VLI7PasfBI2xbHLBU7d2+Xt0Rl/y87xFf/SHAkrK2IUe1 F+S4BHhhxt4FFux/jCsxwE0FPEwb484dPOdRGYa41zG7ENmMgJ7//6JM2xY2jIwxqhTX 0xll3HAsnVEoyrx1Sy/XW90LtNBvCXAUwT5QK2g5Irgu0ZNSlVBeXjRr47iLNsu7bAEE ncCoNTudgOGofMJVYuwVQB7NaT7iCIbTKKstUbYObC4USrweUakGGLTL2tgOtn/1QvlG fzrMufNWpiq7Vm4LAMYyc8YeUSUHWXZKJnepkmjgba0WuVeITVLTj/x/aoeI5ljL1rxH S2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B6C5a8fgXkvGIbXRCUeOuPXtV6lJappdT6WY1SdUJK8=; b=SvehuxUx9CwfYVA1W0tzMiOToSUruA5R457bhZ7Xpe+onKIPE4tzF5ebwCQtr2kqDE 9FhklJ0QxeuD6XwAj3YI9QxeYtr9oYhvjtKQDlwb5DYDEIXklz3R/Z+363ejQ5F8XNoU 6bdYj9GPzfUx4iVbPh1Sq1lPtFueOHMKvcfe6ZBe5+X3j6T9/ByU7GZlPqV5Og0QnnbL cgSbfIrxLxnh9E85zLD5UxQ1qtbKQgf4WN7+9gmtpirBEOphO8gE87CMxRNlRiijtiAZ uRbwB8G+bKBp0gBFCgGkf1gny2nhHoxq9Zilk/w63jqjX9AKdBUpSy6zcbknYHQQriuC QEjg== X-Gm-Message-State: AOAM533dKp7LQsSYN/DXDXrF5c56I++iY/bVJF3QYWgneoNSBBRBzTph c0w9+BHZ5qPOfQKizov+V+Y= X-Google-Smtp-Source: ABdhPJxYImUZ0kyDiYi+dchqS/74s55ZPzFypHvGQY2exP3KxPZCBYRA8LGVoVaLX7NWU0vu9/td0w== X-Received: by 2002:a2e:8858:: with SMTP id z24mr4806581ljj.128.1592679276217; Sat, 20 Jun 2020 11:54:36 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v126sm2219743lfa.50.2020.06.20.11.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 11:54:35 -0700 (PDT) Date: Sat, 20 Jun 2020 21:54:34 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Message-ID: <20200620215434.31802ab4@sovereign> In-Reply-To: <20200618211546.24496-10-talshn@mellanox.com> References: <20200609103139.22168-2-talshn@mellanox.com> <20200618211546.24496-1-talshn@mellanox.com> <20200618211546.24496-10-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [snip] > diff --git a/drivers/meson.build b/drivers/meson.build > index 646a7d5eb5..b25a368531 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -152,16 +152,22 @@ foreach class:dpdk_driver_classes > implib = 'lib' + lib_name + '.dll.a' > > def_file = custom_target(lib_name + '_def', > - command: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'], > + command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'], > input: version_map, > output: '@0@_exports.def'.format(lib_name)) > - lk_deps = [version_map, def_file] > + > + mingw_map = custom_target(name + '_mingw', > + command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'], > + input: version_map, > + output: '@0@_mingw.map'.format(name)) Hit the following error while building a Linux-targeted DPDK: drivers/meson.build:159:3: ERROR: Tried to create target "dpaa_mingw", but a target of that name already exists. Probably you need "lib_name" instead of "name" or just to disable the target for non-Windows builds. > + > + lk_deps = [version_map, def_file, mingw_map] > if is_windows > if is_ms_linker > lk_args = ['-Wl,/def:' + def_file.full_path(), > '-Wl,/implib:drivers\\' + implib] > else > - lk_args = [] > + lk_args = ['-Wl,--version-script=' + mingw_map.full_path()] > endif > else > lk_args = ['-Wl,--version-script=' + version_map] > diff --git a/lib/meson.build b/lib/meson.build > index a8fd317a18..9f6c85a3e1 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -150,18 +150,27 @@ foreach l:libraries > implib = dir_name + '.dll.a' > > def_file = custom_target(name + '_def', > - command: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'], > + command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'], > input: version_map, > output: 'rte_@0@_exports.def'.format(name)) > > + mingw_map = custom_target(name + '_mingw', > + command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'], > + input: version_map, > + output: 'rte_@0@_mingw.map'.format(name)) > + See above on name/lib_name. Maybe it's technically irrelevant here, but better use consistent name generation code. -- Dmitry Kozlyuk