Re: [dpdk-dev] [PATCH v6 1/9] eal: move OS common functions to single file

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

[snip]
> diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> index f162124a37..473c7ac67c 100644
> --- a/lib/librte_eal/linux/eal.c
> +++ b/lib/librte_eal/linux/eal.c
[snip]
>  static int
>  eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
>  {
> @@ -630,6 +590,8 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
>  static int
>  eal_parse_vfio_intr(const char *mode)
>  {
> +	const struct internal_config *internal_conf =
> +			rte_eal_get_internal_configuration();
>  	unsigned i;
>  	static struct {
>  		const char *name;
> @@ -642,7 +604,7 @@ eal_parse_vfio_intr(const char *mode)
>  
>  	for (i = 0; i < RTE_DIM(map); i++) {
>  		if (!strcmp(mode, map[i].name)) {
> -			internal_config.vfio_intr_mode = map[i].value;
> +			internal_conf->vfio_intr_mode = map[i].value;

Linux build error:

../../../../lib/librte_eal/linux/eal.c: In function ‘eal_parse_vfio_intr’:
../../../../lib/librte_eal/linux/eal.c:607:34: error: assignment of member ‘vfio_intr_mode’ in read-only object
  607 |    internal_conf->vfio_intr_mode = map[i].value;

-- 
Dmitry Kozlyuk