From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 796DAA051C; Sat, 20 Jun 2020 21:01:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 133081BFA7; Sat, 20 Jun 2020 21:01:38 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 0042D1BFA2 for ; Sat, 20 Jun 2020 21:01:36 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id g139so6606295lfd.10 for ; Sat, 20 Jun 2020 12:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xT24Ot2lghYD7VTExSDN6qwJU9CaImIWBbauomekFF0=; b=HjvSRC3t8rRv0iGhSkVFOs4C4SvRvt/p4w8VtwUqyWx/+4QG2OvpbbJsi0hP0tAX6B vfuf/SWhATabFnInscCUNTLYMXO1XZTAAbWqUDDc+E/CuzeYADSh/CV4W7dJKs8eb7CS rYxg0X7EetqogdbUo7azh3TZd1xj54sgCPGYyJGu7ObW52gGrplGQCOYfxWj93va5V9r h7aPwajQap1o5zcwPkul+JmK8VYeQOoT07kh8IMG92nMdiMFyGlx2u5HAaOr2r1JFutF 7v76OUDPUOaD4DqMuxPjue9phBxgxELrR3mIoriNrCRi3VSFu0Ep8Jd7W+GBuqt6Lx3B +KVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xT24Ot2lghYD7VTExSDN6qwJU9CaImIWBbauomekFF0=; b=qkrQOBjzl3JNGu6N0mEWklvAk4HdHl6QXG3kkrAB7x8tO3VAlIHudqYgN4xmOue/e0 eFHiEjJ6uKlUh2Om5OupR2jwKalxfr08HUaKInqTXOfU6hvEKQuXZQuUpSUPcLsMoDH5 lhdp2WQeU3c2sVeXJPUudyfdEDVqQkmWNaUUUGkBDKpnkvhKNON8gvpbdBxvn5rNAksJ iUpBA8P9oHzFx3alhrAAL/NNHIbzPglt5i2wLN83W0mXkU0Zkvnf4SSs0tCqVJhPNq0a rrv4GOLMXHeJoi44Sq9J2NOlekFeR8jnG2aBNFcIXA6Yb6iVoRBOnNoDdgDqpfI5SnbN 3T2g== X-Gm-Message-State: AOAM5325u3cGjpvgQ7g2b/wpIX/Oz7OiOl/OQ+n1YAhhcex7RjA24J9m W8Rzy5zzu3NlIrbGHacxnjM= X-Google-Smtp-Source: ABdhPJxSJBHDtC+qsJqrNk3gWGMUvmQB6hZP42zxEYjrTHsrN82qTPbv1i/HzoYlJaSOZJvxweJ1dg== X-Received: by 2002:a05:6512:303:: with SMTP id t3mr5253118lfp.159.1592679696515; Sat, 20 Jun 2020 12:01:36 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id n1sm1814032ljg.131.2020.06.20.12.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 12:01:35 -0700 (PDT) Date: Sat, 20 Jun 2020 22:01:34 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Message-ID: <20200620220134.1d1433fd@sovereign> In-Reply-To: <20200618211546.24496-2-talshn@mellanox.com> References: <20200609103139.22168-2-talshn@mellanox.com> <20200618211546.24496-1-talshn@mellanox.com> <20200618211546.24496-2-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 1/9] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [snip] > diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c > index f162124a37..473c7ac67c 100644 > --- a/lib/librte_eal/linux/eal.c > +++ b/lib/librte_eal/linux/eal.c [snip] > static int > eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) > { > @@ -630,6 +590,8 @@ eal_parse_socket_arg(char *strval, volatile uint64_t = *socket_arg) > static int > eal_parse_vfio_intr(const char *mode) > { > + const struct internal_config *internal_conf =3D > + rte_eal_get_internal_configuration(); > unsigned i; > static struct { > const char *name; > @@ -642,7 +604,7 @@ eal_parse_vfio_intr(const char *mode) > =20 > for (i =3D 0; i < RTE_DIM(map); i++) { > if (!strcmp(mode, map[i].name)) { > - internal_config.vfio_intr_mode =3D map[i].value; > + internal_conf->vfio_intr_mode =3D map[i].value; Linux build error: ../../../../lib/librte_eal/linux/eal.c: In function =E2=80=98eal_parse_vfio= _intr=E2=80=99: ../../../../lib/librte_eal/linux/eal.c:607:34: error: assignment of member = =E2=80=98vfio_intr_mode=E2=80=99 in read-only object 607 | internal_conf->vfio_intr_mode =3D map[i].value; --=20 Dmitry Kozlyuk