From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBCF5A0519; Mon, 22 Jun 2020 15:25:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E125F1D6CA; Mon, 22 Jun 2020 15:25:57 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6205A1D6A2 for ; Mon, 22 Jun 2020 15:25:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592832355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uQ9EJPjJx77667iZDhsdFUm7p4n8V6c/7GxZn2hnQUI=; b=NyymNjPoiIr3xQA2FCxcIA3r//PWk9GnibgP2SGWv3EjEs4xTr8C3bPIULKHRCw6yIxc+s PmQquYEpyP41z61n0/6nwFz00Iz3MthPZKw981NZ8d+q8dfP7wNoFuWxhWqiStalezpaCm atWkN2TkA1czgI4h7Z1FqCL5/wcFgIU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-nr4UevP8NdaPDrfNCGQfjA-1; Mon, 22 Jun 2020 09:25:50 -0400 X-MC-Unique: nr4UevP8NdaPDrfNCGQfjA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA844835B46; Mon, 22 Jun 2020 13:25:48 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A8367167C; Mon, 22 Jun 2020 13:25:45 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: jerinjacobk@gmail.com, bruce.richardson@intel.com, mdr@ashroe.eu, ktraynor@redhat.com, ian.stokes@intel.com, i.maximets@ovn.org Date: Mon, 22 Jun 2020 15:25:22 +0200 Message-Id: <20200622132531.21857-1-david.marchand@redhat.com> In-Reply-To: <20200610144506.30505-1-david.marchand@redhat.com> References: <20200610144506.30505-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/9] Register non-EAL threads as lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OVS and some other applications have been hacking into DPDK internals to fake EAL threads and avoid performance penalty of only having non-EAL threads. This series proposes to add a new type of lcores and maps those threads to such lcores. non-EAL threads won't run the DPDK eal mainloop. As a consequence, part of the EAL threads API cannot work. Having new lcores appearing during the process lifetime is not expected by some DPDK components. This is addressed by introducing init/uninit callacks invoked when hotplugging of such lcore. There is still some work/discussion: - refuse new lcore role in incompatible EAL threads API (or document it only as those API were already incompatible?), - think about deprecation notices for existing RTE_FOREACH_LCORE macros and consorts, it is probably worth discussing on how to iterate over lcores, For the interested parties, I have a patch [1] against dpdk-latest OVS branch that makes use of this series. 1: https://github.com/david-marchand/ovs/commit/dpdk-latest-external-lcores Changes since v2: - fixed windows build error due to missing trace stub, - fixed bug when rolling back on lcore register, Changes since v1: - rebased on master (conflicts on merged Windows series), - separated lcore role code cleanup in a patch, - tried to use a single naming, so kept non-EAL threads as the main notion. non-EAL threads are then distinguished between registered and unregistered non-EAL threads, - added unit tests (still missing some coverage, marked with a FIXME), - reworked callbacks call under a common rwlock lock which protects lcores allocations and callbacks registration, - introduced lcore iterators and converted the bucket mempool driver, -- David Marchand David Marchand (9): eal: relocate per thread symbols to common eal: fix multiple definition of per lcore thread id eal: introduce thread init helper eal: introduce thread uninit helper eal: move lcore role code eal: register non-EAL threads as lcores eal: add lcore init callbacks eal: add lcore iterators mempool/bucket: handle non-EAL lcores MAINTAINERS | 1 + app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_lcores.c | 372 ++++++++++++++++++ doc/guides/howto/debug_troubleshoot.rst | 5 +- .../prog_guide/env_abstraction_layer.rst | 22 +- doc/guides/prog_guide/mempool_lib.rst | 2 +- drivers/mempool/bucket/rte_mempool_bucket.c | 131 +++--- lib/librte_eal/common/eal_common_lcore.c | 240 ++++++++++- lib/librte_eal/common/eal_common_thread.c | 126 ++++-- lib/librte_eal/common/eal_common_trace.c | 51 ++- lib/librte_eal/common/eal_private.h | 19 + lib/librte_eal/common/eal_thread.h | 26 +- lib/librte_eal/common/eal_trace.h | 2 +- lib/librte_eal/freebsd/eal.c | 16 +- lib/librte_eal/freebsd/eal_thread.c | 38 +- lib/librte_eal/include/rte_eal.h | 12 +- lib/librte_eal/include/rte_lcore.h | 167 +++++++- lib/librte_eal/include/rte_trace_point.h | 9 + lib/librte_eal/linux/eal.c | 17 +- lib/librte_eal/linux/eal_thread.c | 38 +- lib/librte_eal/rte_eal_version.map | 16 + lib/librte_eal/windows/eal.c | 8 +- lib/librte_eal/windows/eal_thread.c | 14 +- lib/librte_mempool/rte_mempool.h | 11 +- 26 files changed, 1113 insertions(+), 239 deletions(-) create mode 100644 app/test/test_lcores.c -- 2.23.0