From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B6B9A0350; Wed, 24 Jun 2020 17:09:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 336581D9F3; Wed, 24 Jun 2020 17:09:51 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 292601D9D6 for ; Wed, 24 Jun 2020 17:09:49 +0200 (CEST) IronPort-SDR: 261b87cBFtQtFT1uezyvZTmiy18wIW9quVyN3JynQfHB/lS71TJWG8h0jlrnV+mgHV8NkW4ty5 1/qHmNRufQmg== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="143581581" X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="143581581" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 08:09:48 -0700 IronPort-SDR: NIq3oY23eV9Dcizo8xjdJ939iz3I54RF9QJF0nRv3ZmYvK/XTnFFRJWRRwyjZBY4RjTxow8uxZ gwtum8ckpb1A== X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="423399794" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.2.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 24 Jun 2020 08:09:46 -0700 Date: Wed, 24 Jun 2020 16:09:42 +0100 From: Bruce Richardson To: Ciara Power Cc: kevin.laatz@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org, keith.wiles@intel.com Message-ID: <20200624150942.GA1132@bricha3-MOBL.ger.corp.intel.com> References: <20200612105344.15383-1-ciara.power@intel.com> <20200624134824.16210-1-ciara.power@intel.com> <20200624134824.16210-2-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624134824.16210-2-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 1/2] telemetry: support array values in data objects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote: > Arrays and Dicts now support uint64_t, int and string > array values. Only one level of recursion supported. > > Signed-off-by: Ciara Power > > --- Approach seems good to me, but I think you need more detail in the commit log for this. I think the first sentence needs to make it clearer that its arrays of uint64_t and arrays of int which can be supported as well as arrays of strings. I also think some discussion of why this is necessary is needed in the commit log as well as an explanation of how the memory alloc and free for the array objects work. /Bruce