From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D6AFA0350; Sun, 28 Jun 2020 20:04:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AF201BED0; Sun, 28 Jun 2020 20:04:43 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 4F1F91BE80 for ; Sun, 28 Jun 2020 20:04:42 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id 207so6723642pfu.3 for ; Sun, 28 Jun 2020 11:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F4eRbwU7oKKY0aQ+WSVQSV8Rw4W5DIhNfM9EjpnxxiE=; b=H4bvzgdbYtXspZ+VX84u0ac1qDRKOo4AXGurVK9w/7QsuGZD2XqAj/9EPNU0hedPAx s8cd2GS8aJ54nM2qALIq+ZdT3t4Q8/FlhpRiLDWLN776xWSlumzWRAYk4Xl/IGzbtrH3 XErIAcqSaaJibwcD2kJX99fdmhSU0Ivk1RcdsdGwfsYLh2JrN1MSIrkYbItkiDd+SM2d RHmIC5tQ+gaYVqzw14srj/8YJwfDUZUglyTNZkEiUGzgQzmHisSV+odFnXnRpBpRO6Pe 5kiz3XtKLV+veHhu20OHRZhujV+q2/6svq//ufIj66pcBRolCNLbMugpG3FUyFgT5Fup WuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4eRbwU7oKKY0aQ+WSVQSV8Rw4W5DIhNfM9EjpnxxiE=; b=oIwK3QSumtpj4VxzMWsM0AtWk48zUwSiGIZSUEXOr8RtLjK6qlD7UYFqeGj/OuRFQo BlDRKK8zFX6GS++erpLyQYlRYYuTfTWHJXpsSW1QfW3fdy/e6CZL9n/D5p75cL/SSTPf TACkh7rTIWoCuVNFGKCZcp4A6Xf4buDoMqIqpJ35sPok1fqg53ULF8/l5Lp7J5QzHP0l 4yzwb6zLO6cnredHRc2Ibz+kw/UZUVxBe4agBFKjU579fGz+YPNH+zdPfKWQGBXKY4h7 DeDPtp5FD0eYMtO5J7wloCsztDYwi5/ak+uTByG1rgN37Fef77Woyng3HR3RJFdOp8GU JGmQ== X-Gm-Message-State: AOAM530qeody/pdf1hx1UZ/kFGGRExTDSbmwtQSIT3v8q2rT4ZWZKiuO FFVSv/fKA6eC/HWKiCQdpj9tIA== X-Google-Smtp-Source: ABdhPJy/PDK3LWgCcbEfxM75Mz3yyWgXdjxQuzdU+Eo4tmq+Glq2nu7YtKxEhONhnVNTPoFl6mD0yw== X-Received: by 2002:aa7:9303:: with SMTP id 3mr2310879pfj.108.1593367481381; Sun, 28 Jun 2020 11:04:41 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 22sm13553072pfx.94.2020.06.28.11.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2020 11:04:40 -0700 (PDT) Date: Sun, 28 Jun 2020 11:04:32 -0700 From: Stephen Hemminger To: Fady Bader Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, ranjit.menon@intel.com, pallavi.kadam@intel.com, kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com Message-ID: <20200628110432.09869f0b@hermes.lan> In-Reply-To: <20200628105851.14916-5-fady@mellanox.com> References: <20200625133038.25180-2-fady@mellanox.com> <20200628105851.14916-1-fady@mellanox.com> <20200628105851.14916-5-fady@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 28 Jun 2020 13:58:50 +0300 Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader Maybe ethdev could be modified to not depend on telemetry library directly. The current way means every application gets the telemetry library (on Linux) even though few use it.