From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, bruce.richardson@intel.com,
Neil Horman <nhorman@tuxdriver.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Gagandeep Singh <g.singh@nxp.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-dev] [PATCH v2] build: replace meson OS detection with variable
Date: Tue, 30 Jun 2020 15:15:22 +0200 [thread overview]
Message-ID: <20200630131523.1285693-1-thomas@monjalon.net> (raw)
In-Reply-To: <20200629203656.39052-1-thomas@monjalon.net>
Some places were calling the meson function host_machine.system()
instead of the variables is_windows and is_linux defined
in config/meson.build.
At the same time, the missing "Linux restriction" reason is added to
pfe and octeontx2 crypto PMDs.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: add missing reason to drivers
---
buildtools/pmdinfogen/meson.build | 2 +-
drivers/crypto/octeontx2/meson.build | 5 +++--
drivers/net/pfe/meson.build | 3 ++-
examples/ntb/meson.build | 2 +-
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/buildtools/pmdinfogen/meson.build b/buildtools/pmdinfogen/meson.build
index 7da415b3b7..670528fac7 100644
--- a/buildtools/pmdinfogen/meson.build
+++ b/buildtools/pmdinfogen/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-if host_machine.system() == 'windows'
+if is_windows
subdir_done()
endif
diff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build
index a28c700b9f..0948e73607 100644
--- a/drivers/crypto/octeontx2/meson.build
+++ b/drivers/crypto/octeontx2/meson.build
@@ -1,8 +1,9 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright (C) 2019 Marvell International Ltd.
-if host_machine.system() != 'linux'
- build = false
+if not is_linux
+ build = false
+ reason = 'only supported on Linux'
endif
deps += ['bus_pci']
diff --git a/drivers/net/pfe/meson.build b/drivers/net/pfe/meson.build
index 3e1a228a3f..da0787c28c 100644
--- a/drivers/net/pfe/meson.build
+++ b/drivers/net/pfe/meson.build
@@ -1,8 +1,9 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2019 NXP
-if host_machine.system() != 'linux'
+if not is_linux
build = false
+ reason = 'only supported on Linux'
endif
deps += ['common_dpaax']
diff --git a/examples/ntb/meson.build b/examples/ntb/meson.build
index ab449d0939..45a59350c5 100644
--- a/examples/ntb/meson.build
+++ b/examples/ntb/meson.build
@@ -7,7 +7,7 @@
# DPDK instance, use 'make'
allow_experimental_apis = true
-if host_machine.system() != 'linux'
+if not is_linux
build = false
endif
deps += 'rawdev'
--
2.26.2
next prev parent reply other threads:[~2020-06-30 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:36 [dpdk-dev] [PATCH] " Thomas Monjalon
2020-06-30 12:08 ` Bruce Richardson
2020-06-30 13:15 ` Thomas Monjalon [this message]
2020-06-30 13:23 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-06-30 13:28 ` Akhil Goyal
2020-06-30 13:32 ` Thomas Monjalon
2020-07-01 4:05 ` [dpdk-dev] [EXT] " Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630131523.1285693-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=jingjing.wu@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).